exchanges: Update Poloniex exchange API #2105

samuael · 2025-11-10T05:28:03Z

This is an extension of a PR #1351 (exchanges: Update Poloniex exchange API)

This pull request included a Poloniex exchange code implementation with REST and WebSocket capabilities. The Wrapper and Web-socket functions have all undergone testing. My code conforms to the GCT style standards used by other exchanges.
golangci-lint was used to fix a few mistakes. For future use, endpoint methods that the GCT wrapper does not support are also implemented.

The PR included implementations for REST for trading and other endpoint methods, Web-socket streaming, and Trading through the web socket stream.

Requires #1968

Fixes # (issue)

Type of change

Please delete options that are not relevant and add an x in [] as the item is complete.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

go test ./... -race
golangci-lint run
Test X

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally and on Github Actions/AppVeyor with my changes
Any dependent changes have been merged and published in downstream modules

… into poloniex

…e files

… into update_tif

… into poloniex

… into update_tif

… into poloniex

… into update_tif

… into poloniex

… into update_tif

… into poloniex

shazbert

Thanks, one issue left over.

shazbert · 2026-01-19T04:51:43Z

exchanges/poloniex/poloniex_test.go

+	require.NoError(t, err)
+	assert.NotNil(t, result)
+
+	result, err = e.GetOrderbook(t.Context(), spotTradablePair, .1, 100)


scale is wrong when running live:

Poloniex attempt 1 request path: https://api.poloniex.com/markets/ROCKTRON_USDT/orderBook?limit=100&scale=0.1
Poloniex request type: GET
--- FAIL: TestGetOrderbook (0.43s)
poloniex_test.go:997:
Error Trace: C:/Users/graem/ryan/thrasher-corp/gocryptotrader/exchanges/poloniex/poloniex_test.go:997
Error: Received unexpected error:
Poloniex unsuccessful HTTP status code: 400 raw response: {"code": 24106,"message": "Invalid market depth!"}
Test: TestGetOrderbook

Lock it to BTC then it might work in your favour. Or use 0.0001.... value for scale.

Also when you do these changes please make sure you run it live.

shazbert

🤷

shazbert · 2026-01-19T22:21:45Z

exchanges/poloniex/poloniex_test.go

 	assert.NotNil(t, result)

-	result, err = e.GetOrderbook(t.Context(), spotTradablePair, .1, 100)
+	result, err = e.GetOrderbook(t.Context(), spotPair, .0001, 100)


You didn't test it live 😭

--- FAIL: TestGetOrderbook (1.26s)
poloniex_test.go:999:
Error Trace: C:/Users/ohara/thrasher-corp/gocryptotrader/exchanges/poloniex/poloniex_test.go:999
Error: Received unexpected error:
Poloniex unsuccessful HTTP status code: 400 raw response: {"code": 24106,"message": "Invalid market depth!"}
Test: TestGetOrderbook

cranktakular

This week's batch of changes I must request.

exchanges/poloniex/poloniex_futures_types.go

cranktakular · 2026-01-20T00:33:24Z

exchanges/poloniex/poloniex_test.go

-	err = e.wsHandleData(t.Context(), pressXToJSON)
-	if err != nil {
-		t.Error(err)
+func TestGetCurrentOrders(t *testing.T) {


Reiterating this request for change.

exchanges/poloniex/poloniex.go

cranktakular · 2026-01-20T00:49:46Z

exchanges/poloniex/poloniex.go

-		poloniexOrderMove,
-		values,
-		&result)
+	resp, err := SendBatchValidatedAuthenticatedHTTPRequest[*OrderIDResponse](ctx, e, exchange.RestSpot, sBatchOrderEPL, http.MethodPost, "/orders/batch", nil, args)


This was thumbs-upped, but I'm not getting coverage for this line.

cranktakular · 2026-01-20T04:41:52Z

exchanges/poloniex/ratelimit.go

-		request.Auth:   request.NewRateLimitWithWeight(poloniexRateInterval, poloniexAuthRate, 1),
-		request.UnAuth: request.NewRateLimitWithWeight(poloniexRateInterval, poloniexUnauthRate, 1),
-	}
+var rateLimits = request.RateLimitDefinitions{


The vast majority of other exchanges generate this through a GetRateLimits() function. Three others assign it to a global variable like this, while eleven use a generator function. So I think you should replace it in line with the majority.

Sir, adding another wrapper -- function -- in this case has no semantic or performance advantage. The reason why I did this was also because of someone's comment I don't remember who he was.

That was me, if we have multiple Exchange instances then the rate limits need to be static and shareable

Welp, this minimal implementation can stay for now, but I would like to toss out some ideas for the future.

I wonder if we could retain that static-ness and sharability, without needing to allocate a massive map and to make dozens of function calls even when the exchange isn't used.

Perhaps the global variable could simply be an empty map, with the function being able to check whether it's been allocated, and allocating it once if it hasn't been. Although, we might then need a lock to avoid race conditions....

exchanges/poloniex/poloniex_wrapper.go

cranktakular · 2026-01-20T07:14:48Z

exchanges/poloniex/poloniex_wrapper.go

+					Total:                  bal.AvailableBalance.Float64(),
+					Hold:                   bal.Hold.Float64(),
+					Free:                   bal.Available.Float64(),
+					AvailableWithoutBorrow: bal.AvailableBalance.Float64(),


Not sure this is handling the balances properly.

According to the documentation, Available represents the free balance for spot, while AvailableBalance represents that for futures, so you may need to figure out whether the account is futures or spot, and set the accounts.Balance fields based on that.

Also, I think the current implementation may be neglecting to report on the borrowed amount; I'd think positionMargin + orderMargin would constitute that. And given how there's a distinction between "Free" and "AvailableWithoutBorrow", I'd think that "Free" would have to include any margin.

I am using a single endpoint for this wrapper, and the documentation says nothing about the price toggling for the two account types. May be, I should look at other endpoints alternatives to re-implement this feature. I can/am look into it again if this is assumed to be vital.

It's one endpoint, but as the documentation says, it returns different fields based on whether the account is spot or futures.

This seems, to me, like it is worth getting right.

… into poloniex

shazbert

One last thing from me then looks good to go! nice work!

shazbert · 2026-01-21T00:38:22Z

exchanges/poloniex/poloniex_wrapper.go

 // UpdateTicker updates and returns the ticker for a currency pair
-func (e *Exchange) UpdateTicker(context.Context, currency.Pair, asset.Item) (*ticker.Price, error) {
-	return nil, common.ErrFunctionNotSupported
+func (e *Exchange) UpdateTicker(ctx context.Context, pair currency.Pair, assetType asset.Item) (*ticker.Price, error) {


Need to process these tickers

if err := ticker.ProcessTicker(tickerData); err != nil { return nil, err } return ticker.GetTicker(e.Name, fPair, a)

… into poloniex

shazbert

Nothing more from me thanks!

… into poloniex

shazbert

THings look good, live tests need to be fixed.

shazbert · 2026-01-22T22:55:46Z

exchanges/poloniex/poloniex_websocket.go

+		case "subscribe", "unsubscribe", "error":
+			return conn.RequireMatchWithData("subscription", respRaw)
+		default:
+			return e.Websocket.DataHandler.Send(ctx, websocket.UnhandledMessageWarning{Message: e.Name + websocket.UnhandledMessage + string(respRaw)})


suggestion: You can do what have done below (return an error) and it will be sent. Reducing a bit of code.

shazbert · 2026-01-22T22:58:18Z

exchanges/poloniex/poloniex_live_test.go

+
+	e.setAPICredential(apiKey, apiSecret)
+
 	e.Websocket.DataHandler = sharedtestvalues.GetWebsocketInterfaceChannelOverride()


.\poloniex_live_test.go:29:28: cannot use sharedtestvalues.GetWebsocketInterfaceChannelOverride() (value of type chan any) as *stream.Relay value in assignment

Also fixing this will fix the mess I created on all live tests instances with this recent PR merge. ❤️

Just adding on specific code: I changed this line to:

e.Websocket.DataHandler = stream.NewRelay(10000)

Even with 1M buffer size, it is causing overflow when I test it with credentials live.

I'll have a look look soon

Okeh. You can update /internal/testing/exchange/exchange.go SetupWs and add w.DataHandler = stream.NewRelay(100000) and it resolved it for me

@shazbert may have a differing opinion so I shall tag him

We still have the Poloniex: channel buffer is full: failed to relay <*fmt.wrapError> connection URL:[wss://ws.poloniex.com/ws/public] error: channel buffer is full: failed to relay <[]ticker.Price> on the live tests. but not as big as when we had 10000 buffer size.

gloriousCode

I'm happy with this. I think additional things can be bugfixes/additional PRs. This updates the API, adds extensive coverage, supports new features developed while this PR was opened and meets all my expectations while testing.

Just fix up the live testing bug @shazbert mentioned and maybe remove the lock for websocket spot trade requests (see here)

… into poloniex

samuael added 30 commits April 15, 2025 09:13

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

0f8e310

… into poloniex

fix minor issues based on review comment and move tif code to separat…

2b088d0

…e files

update on exchanges linked to time-in-force

0d22549

resolve missing review comments

dfdbdfc

minor linter issues fix

84eb5b5

added time-in-force handler and update timeInForce parametered endpoint

a9a4bb1

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

a2b5dde

… into update_tif

minor fixes based on review

286aefd

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

6a0559b

… into poloniex

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

b25a7c7

… into update_tif

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

2d19933

… into poloniex

nits fix

6a6e466

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

0b5bb56

… into update_tif

update based on review

f09c0b9

linter fix

9659775

rm getTimeInForce func and minor change to time-in-force

ad6f761

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

2153f77

… into poloniex

Merge branch 'update_tif' into poloniex

650cccb

fix conflict and update unit tests

7bb60a5

minor change

21cd947

update based on review comments

89ff36a

wrappers and time-in-force calling approach

31668c0

minor change

764eb37

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

57e0744

… into poloniex

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

eec47f5

… into poloniex

update gateio string to timeInForce conversion and unit test

9c6f10d

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

84dc671

… into update_tif

Merge branch 'update_tif' into poloniex

c674865

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

f95525c

… into poloniex

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

fa9d9e2

… into poloniex

rm casting

852e5ed

shazbert requested changes Jan 19, 2026

View reviewed changes

temporrary fix to GetOrderbook unit test scale value

73a7337

samuael requested review from shazbert January 19, 2026 22:02

shazbert requested changes Jan 19, 2026

View reviewed changes

cranktakular requested changes Jan 20, 2026

View reviewed changes

samuael requested a review from cranktakular January 20, 2026 22:07

samuael added 5 commits January 21, 2026 01:12

update mock file, improve wrapper, and added test coverage

d46bc99

rm unnecessary comment

653b518

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

8e92d5f

… into poloniex

rn ineffectual assignment

51b8bf8

fix platform-dependent error

2943275

shazbert requested changes Jan 21, 2026

View reviewed changes

samuael added 2 commits January 21, 2026 09:36

add ticker processor to UpdateTicker

69bd301

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

0350ba4

… into poloniex

shazbert approved these changes Jan 22, 2026

View reviewed changes

samuael requested a review from shazbert January 22, 2026 06:23

samuael added 4 commits January 22, 2026 12:32

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

aaa90d1

… into poloniex

linter fix

dd1996e

error return from DataHandler

0b2e2f7

Minor stream data test fix

aabfe5f

shazbert requested changes Jan 22, 2026

View reviewed changes

gloriousCode requested changes Jan 23, 2026

View reviewed changes

fix live test issue

60ed0f3

samuael requested review from gloriousCode and shazbert January 25, 2026 13:35

samuael added 2 commits January 27, 2026 08:37

fix to wrapper balance handling

f11ece6

Merge branch 'master' of http://github.com/thrasher-corp/gocryptotrader…

dd671f2

… into poloniex


		e.setAPICredential(apiKey, apiSecret)

		e.Websocket.DataHandler = sharedtestvalues.GetWebsocketInterfaceChannelOverride()

exchanges: Update Poloniex exchange API #2105

Are you sure you want to change the base?

exchanges: Update Poloniex exchange API #2105

Uh oh!

Conversation

samuael commented Nov 10, 2025

Type of change

How has this been tested

Checklist

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cranktakular left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gloriousCode left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels