exchanges: Update Poloniex exchange API #2105
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package v11 | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
|
|
||
| "github.com/buger/jsonparser" | ||
| ) | ||
|
|
||
| // Version is an ExchangeVersion to replace deprecated WS and REST endpoints for Poloniex | ||
| type Version struct{} | ||
|
|
||
| // Exchanges returns just Poloniex | ||
| func (v *Version) Exchanges() []string { return []string{"Poloniex"} } | ||
|
|
||
| // UpgradeExchange replaces deprecated WS and REST endpoints | ||
| func (v *Version) UpgradeExchange(_ context.Context, e []byte) ([]byte, error) { | ||
| for _, key := range []string{"WebsocketSpotURL", "RestSpotURL"} { | ||
| url, err := jsonparser.GetString(e, "api", "urlEndpoints", key) | ||
| if err != nil && !errors.Is(err, jsonparser.KeyPathNotFoundError) { | ||
| return e, err | ||
| } | ||
| switch url { | ||
| case "wss://api2.poloniex.com", "https://poloniex.com": | ||
| e = jsonparser.Delete(e, "api", "urlEndpoints", key) | ||
| } | ||
| } | ||
| return e, nil | ||
| } | ||
|
|
||
| // DowngradeExchange is a no-op for v11 | ||
| func (v *Version) DowngradeExchange(_ context.Context, e []byte) ([]byte, error) { | ||
| return e, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package v11_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| v11 "github.com/thrasher-corp/gocryptotrader/config/versions/v11" | ||
| ) | ||
|
|
||
| func TestExchanges(t *testing.T) { | ||
| t.Parallel() | ||
| assert.Equal(t, []string{"Poloniex"}, new(v11.Version).Exchanges()) | ||
| } | ||
|
|
||
| func TestUpgradeExchange(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| for _, tt := range []struct { | ||
| in string | ||
| urlType string | ||
| exp string | ||
| }{ | ||
| {"https://poloniex.com", "RestSpotURL", ""}, | ||
| {"https://poloniex.private-proxy.com", "RestSpotURL", `"RestSpotURL": "https://poloniex.private-proxy.com"`}, | ||
| {"wss://api2.poloniex.com", "WebsocketSpotURL", ""}, | ||
| {"wss://poloniex.private-proxy.com", "WebsocketSpotURL", `"WebsocketSpotURL": "wss://poloniex.private-proxy.com"`}, | ||
| } { | ||
| t.Run(tt.in, func(t *testing.T) { | ||
| t.Parallel() | ||
| in := []byte(`{"name":"Poloniex","api":{"urlEndpoints":{"` + tt.urlType + `": "` + tt.in + `"}}}`) | ||
| out, err := new(v11.Version).UpgradeExchange(t.Context(), in) | ||
| require.NoError(t, err) | ||
| exp := `{"name":"Poloniex","api":{"urlEndpoints":{` + tt.exp + `}}}` | ||
| assert.Equal(t, exp, string(out)) | ||
| }) | ||
| } | ||
|
|
||
| in := []byte(`{"name":"Poloniex","api":{}`) | ||
| out, err := new(v11.Version).UpgradeExchange(t.Context(), in) | ||
| require.NoError(t, err, "UpgradeExchange must not error when urlEndpoints is missing") | ||
| assert.Equal(t, string(in), string(out), "UpgradeExchange should return same input and no error when urlEndpoints is missing") | ||
|
|
||
| _, err = new(v11.Version).UpgradeExchange(t.Context(), []byte(`{"name":"Poloniex","api":{"urlEndpoints":{"WebsocketSpotURL": 42}}}`)) | ||
| require.ErrorContains(t, err, "Value is not a string", "UpgradeExchange must error correctly on string value") | ||
| } | ||
|
|
||
| func TestDowngradeExchange(t *testing.T) { | ||
| t.Parallel() | ||
| in := []byte(`{"name":"Poloniex","api":{"urlEndpoints":{"WebsocketSpotURL": 42}}}`) | ||
| out, err := new(v11.Version).DowngradeExchange(t.Context(), in) | ||
| require.NoError(t, err) | ||
| require.Equal(t, string(in), string(out), "DowngradeExchange must not change json") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1364,6 +1364,10 @@ func (u URL) String() string { | |
| return websocketPrivateURL | ||
| case WebsocketSpotSupplementary: | ||
| return websocketSpotSupplementaryURL | ||
| case WebsocketFutures: | ||
| return websocketFuturesURL | ||
| case WebsocketFuturesPrivate: | ||
| return websocketFuturesPrivateURL | ||
| case ChainAnalysis: | ||
| return chainAnalysisURL | ||
| case EdgeCase1: | ||
|
|
@@ -1414,6 +1418,10 @@ func getURLTypeFromString(ep string) (URL, error) { | |
| return WebsocketPrivate, nil | ||
| case websocketSpotSupplementaryURL: | ||
| return WebsocketSpotSupplementary, nil | ||
| case websocketFuturesURL: | ||
| return WebsocketFutures, nil | ||
| case websocketFuturesPrivateURL: | ||
| return WebsocketFuturesPrivate, nil | ||
| case chainAnalysisURL: | ||
| return ChainAnalysis, nil | ||
| case edgeCase1URL: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1649,6 +1649,8 @@ func TestString(t *testing.T) { | |
| {WebsocketTrade, websocketTradeURL}, | ||
| {WebsocketPrivate, websocketPrivateURL}, | ||
| {WebsocketSpotSupplementary, websocketSpotSupplementaryURL}, | ||
| {WebsocketFutures, websocketFuturesURL}, | ||
| {WebsocketFuturesPrivate, websocketFuturesPrivateURL}, | ||
| {ChainAnalysis, chainAnalysisURL}, | ||
| {EdgeCase1, edgeCase1URL}, | ||
| {EdgeCase2, edgeCase2URL}, | ||
|
|
@@ -1813,6 +1815,8 @@ func TestGetGetURLTypeFromString(t *testing.T) { | |
| {Endpoint: websocketTradeURL, Expected: WebsocketTrade}, | ||
| {Endpoint: websocketPrivateURL, Expected: WebsocketPrivate}, | ||
| {Endpoint: websocketSpotSupplementaryURL, Expected: WebsocketSpotSupplementary}, | ||
| {Endpoint: websocketFuturesURL, Expected: WebsocketFutures}, | ||
| {Endpoint: websocketFuturesPrivateURL, Expected: WebsocketFuturesPrivate}, | ||
| {Endpoint: chainAnalysisURL, Expected: ChainAnalysis}, | ||
| {Endpoint: edgeCase1URL, Expected: EdgeCase1}, | ||
| {Endpoint: edgeCase2URL, Expected: EdgeCase2}, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -282,6 +282,8 @@ const ( | |
| WebsocketTrade | ||
| WebsocketPrivate | ||
| WebsocketSpotSupplementary | ||
| WebsocketFutures | ||
| WebsocketFuturesPrivate | ||
| ChainAnalysis | ||
| EdgeCase1 | ||
| EdgeCase2 | ||
|
|
@@ -304,6 +306,8 @@ const ( | |
| websocketTradeURL = "WebsocketTradeURL" | ||
| websocketPrivateURL = "WebsocketPrivateURL" | ||
| websocketSpotSupplementaryURL = "WebsocketSpotSupplementaryURL" | ||
| websocketFuturesURL = "WebsocketFuturesURL" | ||
| websocketFuturesPrivateURL = "WebsocketFuturesPrivateURL" | ||
| chainAnalysisURL = "ChainAnalysisURL" | ||
| edgeCase1URL = "EdgeCase1URL" | ||
| edgeCase2URL = "EdgeCase2URL" | ||
|
|
@@ -328,6 +332,8 @@ var keyURLs = []URL{ | |
| WebsocketTrade, | ||
| WebsocketPrivate, | ||
| WebsocketSpotSupplementary, | ||
| WebsocketFutures, | ||
| WebsocketFuturesPrivate, | ||
| ChainAnalysis, | ||
| EdgeCase1, | ||
| EdgeCase2, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,6 +147,7 @@ type Candle struct { | |
| Low float64 | ||
| Close float64 | ||
| Volume float64 | ||
| QuoteVolume float64 | ||
| ValidationIssues string | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -253,15 +253,13 @@ func MatchAndGetResponse(mockData []HTTPResponse, requestVals url.Values, isQuer | |
| } | ||
|
|
||
| mockVals := url.Values{} | ||
| if json.Valid([]byte(data)) { | ||
| dataMap := make(map[string]any) | ||
| if err := json.Unmarshal([]byte(data), &dataMap); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for k, v := range dataMap { | ||
| switch val := v.(type) { | ||
| case string: | ||
| mockVals.Add(k, val) | ||
|
|
@@ -277,6 +275,7 @@ func MatchAndGetResponse(mockData []HTTPResponse, requestVals url.Values, isQuer | |
| } | ||
| } | ||
| } else { | ||
| var err error | ||
| mockVals, err = url.ParseQuery(data) | ||
| if err != nil { | ||
| return nil, err | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -312,6 +312,8 @@ func TestOrderIs(t *testing.T) { | |
| {Type: StopMarket, Targets: []Type{Stop, Market}}, | ||
| {Type: TrailingStop, Targets: []Type{TrailingStop}}, | ||
| {Type: UnknownType | Limit, Targets: []Type{Limit}}, | ||
| {Type: TrailingStop | Limit, Targets: []Type{TrailingStopLimit, Limit}}, | ||
| {Type: LimitMaker, Targets: []Type{LimitMaker}}, | ||
| {Type: TakeProfitMarket, Targets: []Type{TakeProfit, Market}}, | ||
| } | ||
| for _, oType := range orderComparisonList { | ||
|
|
@@ -358,6 +360,9 @@ func TestOrderTypeToString(t *testing.T) { | |
| {AnyType, "ANY"}, | ||
| {UnknownType | Limit, "LIMIT"}, | ||
| {StopMarket | ConditionalStop, "UNKNOWN"}, | ||
| {TrailingStop | Limit, "TRAILING_STOP_LIMIT"}, | ||
| {TrailingStopLimit, "TRAILING_STOP_LIMIT"}, | ||
| {LimitMaker, "LIMIT_MAKER"}, | ||
| } | ||
| for _, tt := range orderToToStringsList { | ||
| t.Run(tt.String, func(t *testing.T) { | ||
|
|
@@ -846,6 +851,10 @@ func TestStringToOrderType(t *testing.T) { | |
| {"TRIGGER_bracket", Bracket, nil}, | ||
| {"optimal_limit", OptimalLimit, nil}, | ||
| {"OPTIMAL_LIMIT", OptimalLimit, nil}, | ||
| {"TRAILING_STOP_LIMIT", TrailingStopLimit, nil}, | ||
| {"trailing_stop_limit", TrailingStopLimit, nil}, | ||
| {"LIMIT_MAKER", LimitMaker, nil}, | ||
| {"Limit Maker", LimitMaker, nil}, | ||
| } | ||
| for i := range cases { | ||
| testData := &cases[i] | ||
|
|
@@ -1755,3 +1764,23 @@ func TestAdd(t *testing.T) { | |
| c.Add("order1", "cancelled") | ||
| assert.Equal(t, "cancelled", c.Status["order1"]) | ||
| } | ||
|
|
||
| func TestPosition(t *testing.T) { | ||
| t.Parallel() | ||
| input := []struct { | ||
| sides []Side | ||
| side Side | ||
| err error | ||
| }{ | ||
| {[]Side{Short, Sell, Ask}, Short, nil}, | ||
| {[]Side{Long, Buy, Bid}, Long, nil}, | ||
| {[]Side{Side(123)}, UnknownSide, ErrPositionSideUnsupported}, | ||
| } | ||
| for _, a := range input { | ||
| for _, sd := range a.sides { | ||
| side, err := sd.Position() | ||
| assert.Equal(t, a.side, side) | ||
| assert.ErrorIs(t, err, a.err) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,9 @@ var ( | |
| ErrCannotLiquidate = errors.New("cannot liquidate position") | ||
|
|
||
| ErrUnknownTrackingMode = errors.New("unknown tracking mode") | ||
| ErrGetFailed = errors.New("get order failed") | ||
| ErrPlaceFailed = errors.New("place order failed") | ||
| ErrCancelFailed = errors.New("cancel order failed") | ||
| ) | ||
|
|
||
| // Submit contains all properties of an order that may be required | ||
|
|
@@ -372,6 +375,7 @@ const ( | |
| AnyType | ||
| Liquidation | ||
| Trigger | ||
| LimitMaker | ||
| OCO // One-cancels-the-other order | ||
| ConditionalStop // One-way stop order | ||
| TWAP // time-weighted average price | ||
|
|
@@ -380,10 +384,11 @@ const ( | |
| MarketMakerProtection | ||
|
|
||
| // Hybrid order types | ||
| StopLimit = Stop | Limit | ||
| StopMarket = Stop | Market | ||
| TakeProfitMarket = TakeProfit | Market | ||
| TrailingStopLimit = TrailingStop | Limit | ||
| Bracket = Stop | TakeProfit | ||
| ) | ||
|
|
||
| // order-type string representations | ||
|
|
@@ -399,9 +404,11 @@ const ( | |
| orderTakeProfit = "TAKE PROFIT" | ||
| orderTakeProfitMarket = "TAKE PROFIT MARKET" | ||
| orderTrailingStop = "TRAILING_STOP" | ||
| orderTrailingStopLimit = "TRAILING_STOP_LIMIT" | ||
| orderIOS = "IOS" | ||
| orderLiquidation = "LIQUIDATION" | ||
| orderTrigger = "TRIGGER" | ||
| orderLimitMaker = "LIMIT_MAKER" | ||
| orderOCO = "OCO" | ||
| orderOptimalLimit = "OPTIMAL_LIMIT" | ||
| orderMarketMakerProtection = "MMP" | ||
|
|
@@ -413,22 +420,19 @@ const ( | |
| var AllOrderTypes = Limit | | ||
| Market | | ||
| Stop | | ||
| TakeProfit | | ||
| TrailingStop | | ||
| IOS | | ||
| AnyType | | ||
| Liquidation | | ||
| Trigger | | ||
| LimitMaker | | ||
| OCO | | ||
| ConditionalStop | | ||
| TWAP | | ||
| Chase | | ||
| OptimalLimit | | ||
| MarketMakerProtection | ||
|
|
||
| // Side enforces a standard for order sides across the code base | ||
| type Side uint32 | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.