Skip to content

loose events back #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RodrigoHamuy wants to merge 1 commit into from
Closed

loose events back #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions types/three/src/core/EventDispatcher.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export class EventDispatcher<TEventMap extends {} = {}> {
type: T,
listener: EventListener<TEventMap[T], T, this>,
): void;
addEventListener<T extends string>(type: T, listener: EventListener<{}, T, this>): void;

/**
* Checks if listener is added to an event type.
Expand All @@ -63,6 +64,7 @@ export class EventDispatcher<TEventMap extends {} = {}> {
type: T,
listener: EventListener<TEventMap[T], T, this>,
): boolean;
hasEventListener<T extends string>(type: T, listener: EventListener<{}, T, this>): boolean;

/**
* Removes a listener from an event type.
Expand All @@ -73,6 +75,7 @@ export class EventDispatcher<TEventMap extends {} = {}> {
type: T,
listener: EventListener<TEventMap[T], T, this>,
): void;
removeEventListener<T extends string>(type: T, listener: EventListener<{}, T, this>): void;

/**
* Fire an event type.
Expand Down
23 changes: 21 additions & 2 deletions types/three/test/unit/src/core/EventDispatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,27 @@ eveDisForTestEvent.addEventListener("bar", e => {
e.foo;
});

// @ts-expect-error
eveDisForTestEvent.addEventListener("baz", e => {});
// call addEventListener with an unknown event. The typing should allow you listen any unknown event.
eveDisForTestEvent.addEventListener("baz", e => {
e.type; // $ExpectType "baz"
e.target; // $ExpectType EventDispatcher<TestEvent>
// @ts-expect-error
e.bar;
// @ts-expect-error
e.foo;
// @ts-expect-error
e.bar();
});
eveDisForTestEvent.addEventListener("NotRegistered", e => {
e.type; // $ExpectType "NotRegistered"
e.target; // $ExpectType EventDispatcher<TestEvent>
// @ts-expect-error
e.bar;
// @ts-expect-error
e.foo;
// @ts-expect-error
e.bar();
});

eveDisForTestEvent.dispatchEvent({ type: "foo", foo: 42 });
eveDisForTestEvent.dispatchEvent({ type: "bar", bar: "42" });
Expand Down