Improve the WalletRegistry.getWalletPublicKey function#821
Open
r-czajkowski wants to merge 1 commit intomainfrom
Open
Improve the WalletRegistry.getWalletPublicKey function#821r-czajkowski wants to merge 1 commit intomainfrom
WalletRegistry.getWalletPublicKey function#821r-czajkowski wants to merge 1 commit intomainfrom
Conversation
Skip retrying when the contract throws an error saying the wallet with the given ID has not been registered. There is no need to retry this request because the contract responds with the exact reason - the wallet does not exist.
r-czajkowski
force-pushed
the
improve-get-wallet-public-key
branch
from
20f9087 to
3c1af2c
Compare
r-czajkowski
changed the title
WalletRegistry.getWalletPublicKey fnWalletRegistry.getWalletPublicKey function
nkuba
reviewed
Aug 6, 2024
| this._totalRetryAttempts, | ||
| undefined, | ||
| undefined, | ||
| skipRetryWhenMatched(["Wallet with the given ID has not been registered"]) |
Member
There was a problem hiding this comment.
I'm not sure we can safely skip this error. We want to work around the problem in the redemption process, but the getWalletPublicKey function can be used in other processes as well.
If someone calls getWalletPublicKey right after a fresh wallet creation there is a chance that chain endpoint hasn't synced yet and the retry would be desirable here.
Maybe we should add an optional argument skipRetryWhenNotRegistered = false and use this variant only in the redemption process?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloese: #815
Skip retrying when the contract throws an error saying the wallet with the given ID has not been registered. There is no need to retry this request because the contract responds with the exact reason - the wallet does not exist. As Łukasz mentioned in #815 it happens because closed/terminated wallets are no longer in the contract state so,
getWalletCompressedPublicKeythrows while callinggetWalletPublicKey.