Skip to content

fix: display Settings reset/mix up when toggling "Colorize contact pictures" #10259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wmontwe merged 1 commit into from
Dec 17, 2025
Merged

fix: display Settings reset/mix up when toggling "Colorize contact pictures" #10259

wmontwe merged 1 commit into from
Dec 17, 2025
+20 −0

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Dec 13, 2025 •
edited
Loading

🐛 Root Cause of the Bug

  • All Message List–related display settings were not being loaded from PreferenceStorage; instead, they were retrieved from the default values defined in their corresponding Settings class.
  • Additionally, whenever Message List–related display settings were being saved, they were not persisted because the corresponding storage editors were not committing the changes.

💡 Solution

  • Integrate the message list preferences so they combine correctly with existing general and display settings.
  • Commit changes to the preference store when the corresponding settings are saved.

@shamim-emon shamim-emon requested a review from a team as a code owner December 13, 2025 10:57
dani-zilla
dani-zilla requested changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could drop the logging, but I did want to ask if you were able to reproduce this in a newer version of the app. I could not reproduce it on v14 from Google Play or v17 from a fresh debug build, not with the existing views or compose either. Do you have any additional info on how this fix could be tested between the latest beta and this version?

Thanks!

legacy/core/src/main/java/com/fsck/k9/preferences/DefaultGeneralSettingsManager.kt
)
}
.combine(messageListPreferencesManager.getConfigFlow()) { generalSettings, messageListSettings ->
logger.debug { "messageListSettings: $messageListSettings" }
Copy link
Contributor

@dani-zilla dani-zilla Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that logger is currently not recommended:

"Use a net.thunderbird.core.logging.Logger instance via dependency injection instead. " +
        "This class will be removed in a future release.",

Copy link
Collaborator Author

@shamim-emon shamim-emon Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, now injecting net.thunderbird.core.logging.Logger instance instead as per suggestion.

@shamim-emon
Copy link
Collaborator Author

shamim-emon commented Dec 16, 2025

I think we could drop the logging, but I did want to ask if you were able to reproduce this in a newer version of the app. I could not reproduce it on v14 from Google Play or v17 from a fresh debug build, not with the existing views or compose either. Do you have any additional info on how this fix could be tested between the latest beta and this version?

Thanks!

@dani-zilla I am able to reproduce this on latest debug build. In-case you don't see the issue, toggle Colorize contact pictures value and then restart the app, you will see this value along with any value from MessageList settings is not persisted.

dani-zilla
dani-zilla approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to reproduce it with the force quit method. Thanks for that! Bug seems to be fixed in build and looks good to me. Thanks!

@wmontwe wmontwe changed the title Display Settings reset/mix up when toggling "Colorize contact pictures" fix: display Settings reset/mix up when toggling "Colorize contact pictures" Dec 17, 2025
@wmontwe wmontwe merged commit 22eebd9 into thunderbird:main Dec 17, 2025
13 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Dec 17, 2025
@shamim-emon shamim-emon deleted the fix-issue-9630 branch December 17, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dani-zilla dani-zilla dani-zilla approved these changes

Assignees

@dani-zilla dani-zilla

Labels

None yet

Projects

None yet

Milestone

Thunderbird 17

Development

Successfully merging this pull request may close these issues.

Display Settings reset/mix up when toggling "Colorize contact pictures"

3 participants

@shamim-emon @dani-zilla @wmontwe