Skip to content

Migrate K9.isDebugLoggingEnabled to PreferenceDataStore #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaeltonholo merged 3 commits into from
Aug 7, 2025
Merged

Migrate K9.isDebugLoggingEnabled to PreferenceDataStore #9509

rafaeltonholo merged 3 commits into from
Aug 7, 2025

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Jul 25, 2025 •
edited
Loading

Implementation Highlights

  • Implemented buildFeature in core.preference module and shared BuildConfig's DEBUG flag through expect-actual pattern in commonMain.
  • Migrate K9.isDebugLoggingEnabled to PreferenceDataStore.

@shamim-emon shamim-emon requested a review from a team as a code owner July 25, 2025 20:45
@shamim-emon shamim-emon force-pushed the fix-issue-9456 branch 2 times, most recently from dfd3b63 to 111fd27 Compare July 27, 2025 09:16
@shamim-emon shamim-emon mentioned this pull request Jul 27, 2025
Merged
rafaeltonholo
rafaeltonholo requested changes Jul 29, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributtion, but there are a few comments that needs to be addressed before merging this

@shamim-emon shamim-emon force-pushed the fix-issue-9456 branch 2 times, most recently from 4322638 to 7f5cfc5 Compare August 5, 2025 03:20
@shamim-emon shamim-emon mentioned this pull request Aug 5, 2025
Closed
rafaeltonholo
rafaeltonholo requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the previous comments, however, there are a few still missing:

  • Revert AttachmentProvider.java changes
  • Revert RawMessageProvider.java changes
  • Revert MlfUtils.java changes.

Additionally, with the introduction of the DebugLogConfiguration into :logging/impl-legacy, you need to remove the legacy/core/src/main/java/com/fsck/k9/preferences/DebugLogConfigurator.kt, to avoid code duplication.

rafaeltonholo
rafaeltonholo approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for addressing all the comments and for this contribution!

@rafaeltonholo rafaeltonholo merged commit c76a216 into thunderbird:main Aug 7, 2025
4 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Aug 7, 2025
@shamim-emon shamim-emon deleted the fix-issue-9456 branch August 7, 2025 12:32
@rafaeltonholo rafaeltonholo mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

@wmontwe wmontwe Awaiting requested review from wmontwe

Assignees

@wmontwe wmontwe

@rafaeltonholo rafaeltonholo

Labels

None yet

Projects

None yet

Milestone

Thunderbird 13

Development

Successfully merging this pull request may close these issues.

Migrate K9.isDebugLoggingEnabled to PreferenceDataStore

3 participants

@shamim-emon @wmontwe @rafaeltonholo