refactor(notifications): change in-app notifications to accept only a single style per type#9631
Merged
rafaeltonholo merged 1 commit intothunderbird:mainfrom Sep 8, 2025
Conversation
rafaeltonholo
force-pushed
the
feat/9312/change-in-app-notification-style-to-one-style
branch
5 times, most recently
from
826fd70 to
a5e1e80
Compare
rafaeltonholo
force-pushed
the
feat/9312/change-in-app-notification-style-to-one-style
branch
from
a5e1e80 to
166378b
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
force-pushed
the
feat/9312/change-in-app-notification-style-to-one-style
branch
from
166378b to
f194702
Compare
… single style per type
rafaeltonholo
force-pushed
the
feat/9312/change-in-app-notification-style-to-one-style
branch
from
f194702 to
d3db66b
Compare
asoucar
approved these changes
Sep 8, 2025
rafaeltonholo
deleted the
feat/9312/change-in-app-notification-style-to-one-style
branch
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9312.
After talking with the design team, we conclude that each notification type should have only one in-app notification style. This PR is meant to address that change by migrating
InAppNotification.inAppNotificationStyles: List<InAppNotificationStyle>toInAppNotification.inAppNotificationStyle: InAppNotificationStyle.