feat(notifications): in-app notifications with Message List integration #9660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeltonholo
force-pushed
the
feat/9312/in-app-notification-message-list-integration
branch
from
1d6a960 to
8ad2bff
Compare
rafaeltonholo
changed the title
rafaeltonholo
force-pushed
the
feat/9312/in-app-notification-message-list-integration
branch
2 times, most recently
from
51f3b40 to
8e8e498
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
wmontwe
previously approved these changes
Sep 16, 2025
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
LGTM
Just observed that there are no tests to cover these code changes.
...pi/src/commonMain/kotlin/net/thunderbird/feature/notification/api/content/AppNotification.kt
Show resolved
Hide resolved
...onMain/kotlin/net/thunderbird/feature/notification/api/content/FailedToCreateNotification.kt
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Outdated
Show resolved
Hide resolved
...gacy/src/main/java/com/fsck/k9/ui/messagelist/item/MessageListInAppNotificationViewHolder.kt
Outdated
Show resolved
Hide resolved
...i/src/commonMain/kotlin/net/thunderbird/feature/notification/api/content/MailNotification.kt
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListAdapter.kt
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListAdapter.kt
Show resolved
Hide resolved
…ter in wrong string fix(notifications): fix all string parameter missing index (compose resource requirement)
…fications with message list
…nabling notification filtering
…pdateIncomingServerSettings or UpdateOutgoingServerSettings
rafaeltonholo
force-pushed
the
feat/9312/in-app-notification-message-list-integration
branch
from
8e8e498 to
a86115b
Compare
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
deleted the
feat/9312/in-app-notification-message-list-integration
branch
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9312.
Depends on #9631.