-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Rewrite AutocryptHeaderParser and AutocryptGossipHeaderParser in Kotlin #9831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f93aa7 to
4c566e3
Compare
rafaeltonholo
requested changes
Sep 30, 2025
Member
rafaeltonholo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. I have left a few comments that need to be addressed before merging this.
legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.kt
Outdated
Show resolved
Hide resolved
legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptHeaderParser.kt
Outdated
Show resolved
Hide resolved
legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptOperations.java
Outdated
Show resolved
Hide resolved
legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.kt
Show resolved
Hide resolved
legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.kt
Outdated
Show resolved
Hide resolved
4c566e3 to
9cbf0ea
Compare
…Parser and AutocryptGossipHeaderParser
9cbf0ea to
563aa61
Compare
rafaeltonholo
approved these changes
Oct 1, 2025
Member
rafaeltonholo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing all the comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the
AutocryptHeaderParserandAutocryptGossipHeaderParserclasses from Java to Kotlin. The conversion enhances code readability, maintains existing functionality, and aligns with Kotlin best practices.Key Changes: