Skip to content

Conversation

@hbugdoll
Copy link
Contributor

@hbugdoll hbugdoll commented Nov 12, 2025

After #14340 here comes a larger PR.

Description

Fixes in logs and comments:

  • fixed typos
  • fixed wording: ABI, Android, API, AVD, CI, CLI, CPU, e.g., HTML, iOS, iPad, Java, JavaScript, JDK, JNI, JS, JSON, macOS, PDF, SDK, Titanium, TODO, URI, URL, Windows (the OS), XML
  • fixed i.e.e.g. in sense of an example
  • fixed apostrophe in contractions don't, doesn't, ...


Fixes in code (not API-relevant):

  • variable overridenLayoutoverriddenLayout
  • variable resultElemetresultElement
  • variable tempLenghttempLength
  • variable unstrechedSizeunstretchedSize
  • variable TiCanvasFillElipseTiCanvasFillEllipse
  • variable initBackGroundinitBackground
  • function initSearhControllerinitSearchController in TiUITableView
  • function test_AbsoluteLayout_LeftProperytest_AbsoluteLayout_LeftProperty
  • function test_AbsoluteLayout_RightProperytest_AbsoluteLayout_RightProperty
  • function test_AbsoluteLayout_TopProperytest_AbsoluteLayout_TopProperty
  • function test_AbsoluteLayout_BottomProperytest_AbsoluteLayout_BottomProperty

Fixes in code (API-relevant):

  • 
function deleteAllSearchableItemByDomainIdenifiers:deleteAllSearchableItemByDomainIdentifiers: in TiAppiOSSearchableIndexProxy
    • marked deleteAllSearchableItemByDomainIdenifiers: as deprecated
  • function isOrientationPortaitisOrientationPortrait in TiUtils
    • marked isOrientationPortait as deprecated

Fixes in code (potential bugs):

  • call ENSURE_IOS_API(@"10", @"Ti.App.iOS.SearchableItemAttributSet.postalCode")ENSURE_IOS_API(@"10", @"Ti.App.iOS.SearchableItemAttributeSet.postalCode")

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. May take a short bit to review.

@hbugdoll
Copy link
Contributor Author

May take a short bit to review.

Of course!

One last load was added: 464670e

@cb1kenobi cb1kenobi self-requested a review November 12, 2025 21:11
Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback (still 100 to check 😄 )

Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small note

@m1ga
Copy link
Contributor

m1ga commented Nov 12, 2025

Awesome PR 👍 I didn't test the iOS deprecation parts (deleteAllSearchableItemByDomainIdenifiers) and I think the isOrientationPortrait needs to be changed in the TiUtils files as that should be the variable that is returned.

Everything else looks fine. Well done!

@hbugdoll
Copy link
Contributor Author

@cb1kenobi @m1ga Thank you very much for your comprehensive reviews!

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hbugdoll!

@m1ga I'll wait to merge until you sign off on things. Thanks!

@m1ga
Copy link
Contributor

m1ga commented Nov 13, 2025

let me quickly build an app with it to see if everything still works.
But otherwise it looks fine

@m1ga m1ga self-requested a review November 13, 2025 17:23
Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine 👍

@hbugdoll
Copy link
Contributor Author

hbugdoll commented Nov 13, 2025

I tested the mocha app under iOS – runs as before.

Ti.Gesture.portrait is also working fine.
Calling isOrientationPortait in GestureModule the deprecation warning is raised during build process (as desired).

@cb1kenobi cb1kenobi merged commit b55d18a into tidev:main Nov 14, 2025
8 checks passed
@hbugdoll hbugdoll deleted the typos-fix branch November 14, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants