-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: fixed further typos and wording #14341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb1kenobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. May take a short bit to review.
Of course! One last load was added: 464670e |
m1ga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback (still 100 to check 😄 )
android/modules/contacts/src/java/ti/modules/titanium/contacts/CommonContactsApi.java
Outdated
Show resolved
Hide resolved
m1ga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small note
|
Awesome PR 👍 I didn't test the iOS deprecation parts (deleteAllSearchableItemByDomainIdenifiers) and I think the Everything else looks fine. Well done! |
android/modules/contacts/src/java/ti/modules/titanium/contacts/CommonContactsApi.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Barber <[email protected]>
|
@cb1kenobi @m1ga Thank you very much for your comprehensive reviews! |
cb1kenobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
let me quickly build an app with it to see if everything still works. |
m1ga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working fine 👍
|
I tested the mocha app under iOS – runs as before.
|
After #14340 here comes a larger PR.
Description
Fixes in logs and comments:
ABI,Android,API,AVD,CI,CLI,CPU,e.g.,HTML,iOS,iPad,Java,JavaScript,JDK,JNI,JS,JSON,macOS,PDF,SDK,Titanium,TODO,URI,URL,Windows(the OS),XMLi.e.→e.g.in sense of an exampledon't,doesn't, ...Fixes in code (not API-relevant):
overridenLayout→overriddenLayoutresultElemet→resultElementtempLenght→tempLengthunstrechedSize→unstretchedSizeTiCanvasFillElipse→TiCanvasFillEllipseinitBackGround→initBackgroundinitSearhController→initSearchControllerinTiUITableViewtest_AbsoluteLayout_LeftPropery→test_AbsoluteLayout_LeftPropertytest_AbsoluteLayout_RightPropery→test_AbsoluteLayout_RightPropertytest_AbsoluteLayout_TopPropery→test_AbsoluteLayout_TopPropertytest_AbsoluteLayout_BottomPropery→test_AbsoluteLayout_BottomPropertyFixes in code (API-relevant):
deleteAllSearchableItemByDomainIdenifiers:→deleteAllSearchableItemByDomainIdentifiers:inTiAppiOSSearchableIndexProxydeleteAllSearchableItemByDomainIdenifiers:as deprecatedisOrientationPortait→isOrientationPortraitinTiUtilsisOrientationPortaitas deprecatedFixes in code (potential bugs):
ENSURE_IOS_API(@"10", @"Ti.App.iOS.SearchableItemAttributSet.postalCode")→ENSURE_IOS_API(@"10", @"Ti.App.iOS.SearchableItemAttributeSet.postalCode")