Fix for resolution - if all differences less than tolerance, return 1 #6630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Sep 19, 2025
Member
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
Small improvement but otherwise good. Thanks!
Comment on lines
+37
to
+43
|
|
||
| if(all(d < tolerance)){ | ||
| return(1) | ||
| } | ||
|
|
||
| min(d[d > tolerance]) | ||
|
|
Member
There was a problem hiding this comment.
Thanks for this. I think this can be solved with fewer computations by doing something min(d[d > tolerance], 1)
Contributor
Author
There was a problem hiding this comment.
Ah, that's a good alternative
Member
There was a problem hiding this comment.
oh, I completely messed up in that suggestion. Sorry about that.
You can revert to your old approach
Member
There was a problem hiding this comment.
You need to remove the , 1 from the last call :-)
thomasp85
approved these changes
Sep 19, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6562