Skip to content

Fix for resolution - if all differences less than tolerance, return 1 #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Fix for resolution - if all differences less than tolerance, return 1 #6630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f80abd
Fix for resolution - if all differences less than tolerance, return 1
laderast Sep 19, 2025
5eb0456
update
laderast Sep 19, 2025
9700466
reverting back
laderast Sep 19, 2025
128392b
removing ",1" from line 42
laderast Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion R/utilities-resolution.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
#' The resolution is the smallest non-zero distance between adjacent
#' values. If there is only one unique value, then the resolution is defined
#' to be one. If x is an integer vector, then it is assumed to represent a
#' discrete variable, and the resolution is 1.
#' discrete variable, and the resolution is 1. If the differences are all smaller
#' than the tolerance, set resolution to 1.
#'
#' @param x numeric vector
#' @param zero should a zero value be automatically included in the
Expand Down Expand Up @@ -33,5 +34,11 @@ resolution <- function(x, zero = TRUE, discrete = FALSE) {
}
d <- diff(sort(x))
tolerance <- sqrt(.Machine$double.eps)

if(all(d < tolerance)){
return(1)
}

min(d[d > tolerance])

Comment on lines +37 to +43
Copy link
Member

@thomasp85 thomasp85 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think this can be solved with fewer computations by doing something min(d[d > tolerance], 1)

Copy link
Contributor Author

@laderast laderast Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good alternative

Copy link
Member

@thomasp85 thomasp85 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I completely messed up in that suggestion. Sorry about that.

You can revert to your old approach

Copy link
Member

@thomasp85 thomasp85 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the , 1 from the last call :-)

Copy link
Contributor Author

@laderast laderast Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, will fix

}
3 changes: 2 additions & 1 deletion man/resolution.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading