Skip to content

Comments

chore: fix rclcpp version#225

Merged
iwatake2222 merged 1 commit intorc/v0.6.2-rclcpp-t4-main-caret-add-agnocastfrom
chore_fix_rclcpp_hash
Jan 14, 2026
Merged

chore: fix rclcpp version#225
iwatake2222 merged 1 commit intorc/v0.6.2-rclcpp-t4-main-caret-add-agnocastfrom
chore_fix_rclcpp_hash

Conversation

@iwatake2222
Copy link
Contributor

@iwatake2222 iwatake2222 commented Jan 14, 2026

Description

  • Use a commit hash instead of a branch name for rclcpp.

Background

launch_ros rclcpp Result
(~2026/1/13) Pilot.Auto w/ and w/o CARET customized customized OK
(2026/1/13~) Pilot.Auto w/o CARET reverted reverted + QoS modified OK
(2026/1/13~) Pilot.Auto(older version) w/ CARET without this PR customized reverted + QoS modified (t4-main-caret branch) Incompatible
(2026/1/13~) Pilot.Auto(newer version) w/ CARET without this PR reverted reverted + QoS modified (t4-main-caret branch) OK
(2026/1/13~) Pilot.Auto(older version) w/ CARET with this PR customized customized (4a026d54) OK
(2026/1/13~) Pilot.Auto(newer version) w/ CARET with this PR reverted customized (4a026d54) OK

Related links

Notes for reviewers

  • This change will be reverted in the future when Pilot.Auto doesn't rely on a customized version of launch_ros
  • or, we can move on a new version of CARET (v0.7.0)

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
@iwatake2222 iwatake2222 changed the title chore: fix rclcpp hash because branch will be changed chore: fix rclcpp version Jan 14, 2026
@iwatake2222
Copy link
Contributor Author

@interimadd
Could you review this PR?
I just use a commit hash instead of a branch name for rclcpp. So that , the appropriate tier4/rclcpp is used in case Pilot.Auto uses tier4/launch_ros (especially the older version of Pilot.Auto)

Copy link

@interimadd interimadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick handling.

@iwatake2222 iwatake2222 merged commit a14a8a1 into rc/v0.6.2-rclcpp-t4-main-caret-add-agnocast Jan 14, 2026
17 checks passed
@iwatake2222 iwatake2222 deleted the chore_fix_rclcpp_hash branch January 14, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants