feat(rclcpp_components): change load_node service QoS to prevent failure on loading composable node for caret branch#15
Open
interimadd wants to merge 2 commits intot4-main-caretfrom
Conversation
…-qos feat(rclcpp_components): change load_node service QoS to prevent failure on loading composable node.
iwatake2222
requested changes
Jan 14, 2026
There was a problem hiding this comment.
@interimadd
LGTM!
However, please hold off on merging until the Pilot.Auto v0.61 release evaluation is completed. The reason is that v0.61 uses a forked version of launch_ros, which requires the pre-change version of rclcpp. In addition, the rclcpp used for CARET evaluation is specified by branch name, so merging this change would cause an inconsistency.
(To avoid an accidental merge, I’m changing the review status to “Request changes.”)
Note:
After merging tier4/caret#225, we can merge this PR. However, I'd like to wait the Pilot.Auto v0.61 release completion for the safe.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply #14 to t4-main-caret branch
Test
Pilot.Auto can be built successfully.
And I confirmed that Pilot.Auto can drive a car in AWSIM with following command.
Related Link
https://tier4.atlassian.net/browse/T4DEV-45284