Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,13 @@ Referencing `TASKS.md` PR order:
## Copilot Review Priorities

1. **GitHub Staging Files**: Any files in `.github-staging/` directory MUST be manually reviewed before moving to `.github/`. Never automatically move or activate these files. See `.github-staging/README.md` for review process.
2. **Release Notes**: Verify `CHANGELOG.md` has been updated with a brief description of changes for user-facing or significant technical updates. Skip only for CI plumbing, refactoring, test-only changes, and bot PRs (dependabot, Jules).
3. Security & Data Integrity: Input validation, single-tenant assumptions honored, issue-machine relationship enforced.
4. Server-First Compliance: Avoid unnecessary `"use client"`.
5. Type Safety: No forbidden escapes; proper narrowing.
6. Progressive Enhancement: `<form action={serverAction}>` patterns validated.
7. Memory Safety & Test Patterns: Worker-scoped DB setup; no per-test instances.
8. Domain Consistency: Issue severity vocabulary and one-machine rule.
9. **E2E Test Quality**: Follow `docs/E2E_BEST_PRACTICES.md` - semantic selectors (role + name), no hard-coded delays, independent tests, descriptive names, reusable actions extracted. Validate critical user journeys only, avoid testing implementation details or edge cases.
2. Security & Data Integrity: Input validation, single-tenant assumptions honored, issue-machine relationship enforced.
3. Server-First Compliance: Avoid unnecessary `"use client"`.
4. Type Safety: No forbidden escapes; proper narrowing.
5. Progressive Enhancement: `<form action={serverAction}>` patterns validated.
6. Memory Safety & Test Patterns: Worker-scoped DB setup; no per-test instances.
7. Domain Consistency: Issue severity vocabulary and one-machine rule.
8. **E2E Test Quality**: Follow `docs/E2E_BEST_PRACTICES.md` - semantic selectors (role + name), no hard-coded delays, independent tests, descriptive names, reusable actions extracted. Validate critical user journeys only, avoid testing implementation details or edge cases.

## Preferred Implementation Examples

Expand Down
25 changes: 0 additions & 25 deletions CHANGELOG.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/plans/2025-12-27-unconfirmed-users-design.md
Original file line number Diff line number Diff line change
Expand Up @@ -691,4 +691,3 @@ type MachineOwner = {

- `docs/PRODUCT_SPEC.md` - Update to mark MVP+ status
- `docs/NON_NEGOTIABLES.md` - Add any new patterns/constraints
- `CHANGELOG.md` - Document this feature when shipped
2 changes: 1 addition & 1 deletion src/components/layout/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export function Sidebar({
)}
</div>

{/* Help / Changelog + Collapse (bottom) */}
{/* Help + Collapse (bottom) */}
<div className="border-t border-border px-2 pt-3 pb-2 space-y-2">
<div className="space-y-1">
<NavItem
Expand Down
Loading