Skip to content

Conversation

@gen2thomas
Copy link

@gen2thomas gen2thomas commented Oct 19, 2025

see #789

Some notes:

Install the linter locally by: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.5.0 or by a way of your choice: https://golangci-lint.run/docs/welcome/install/#local-installation.

The current linter configuration is quite long, because we drop many linters caused by a single or only a few findings. This will usually decreased by the time, when those findings are fixed.

Because we have to skip some packages and this is not supported by the linters, we have to apply the linter to each allowed package (folder) separately.

This leads to following behavior for local run:

  • all directories needs to be given as space separated list

This leads to following behavior for CI run when using the make file in docker container or plain setup in runner (currently implemented in this PR):

  • provided GitHub Action is not used
  • nice features for CI check can not be used, e.g. show findings inline

Alternatively, there are 2 other PRs using GitHub Action:

One other alternative way for CI would be to collect all usable packages in another folder and set this as the working directory, but this would introduce other problems:

  • inline annotations will be lost, because we check another file internally
  • dependencies to "own" drivers package are ambiguous

TODO:

  • filter packages without dependency to "machine" imports
  • add new targets to Makefile
  • introduce linter configuration file
  • fix all serious issues in code, normally found by "go vet" ("make check")
  • tweak the configuration file
  • introduce files running for CI
  • fix all important issues in code
  • discuss about fix of small problems, e.g. unused variables etc.

@gen2thomas gen2thomas force-pushed the feature/linter branch 30 times, most recently from cf7063c to 10751ed Compare October 21, 2025 18:17
@gen2thomas gen2thomas force-pushed the feature/linter branch 7 times, most recently from 8ef1fd4 to 534d4c1 Compare October 22, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant