Refactor names related to textures (low priority)#770
Merged
andrewlook merged 3 commits intomainfrom Sep 9, 2025
Merged
Conversation
zranger1
approved these changes
Aug 25, 2025
Collaborator
zranger1
left a comment
There was a problem hiding this comment.
Looks good! Tested - the iChannel[n] textures and internal coordinate and indexing samplers are all working. I especially appreciate the cleanup of the messy naming around the shadertoy-compatible iChannels. That's been around since before year 1, and it has always been confusing.
Approved, but maybe hold merge 'till after the burn.
Collaborator
|
note: i merged the stacked PR #773 into this branch, then will rebase it into master (to preserve the 3 resulting commits) |
Collaborator
|
thanks for thinking ahead here @jkbelcher to make the naming something that is clearer before we keep adding stuff onto this 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a refactor pass (name changes only) to clarify a few things:
There were places where "coords" was used in reference to both model-derived textures, and places where "coords" was used only in reference to the first texture. Attempting to create consistency I chose: