Open
Conversation
added 13 commits
January 26, 2015 13:43
…suite checks for same
…e or negative for a given employee
Contributor
There was a problem hiding this comment.
You wrote a README! You may be the only one who listened to me!
Contributor
|
Christen - As always, excellent work. I made a few comments throughout on style and convention, but nothing on functionality. I'll also comment that your commit messages should take the present-tense singular form. Well done! In case you were wondering (and I know you're not), I have no concerns with your progress in the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard mode working. Run employee_reviews.rb for a test case, and run employee_reviews_test.rb for the test suite.
Employee reviews are read in from sample_reviews.txt in the test case.