Update Kingfisher #56
Conversation
|
Hi @casperriboe. Thanks! The SDK is deprecated and replaced with a newer solution. Which retailer are you working for? We can inform you about the new solution then. |
Hey @mortenbo 👋🏻 Our resources are limited at the moment, so we won't be able to migrate to the newer solution. I don't mind if you don't like to merge this because we can just use my fork 🙂 |
|
If you don't mind, then go ahead with the fork. Could you also instruct your client in we have a new solution and they ought to upgrade? We'll help with all the changes needed. |
Will do, thanks ✌🏻 Maybe this repository should be locked to read-only so people like me don't go around opening pull requests 😄 |
2 participants
Hi!
The current Kingfisher dependency is quite old by targeting version 7 and hinders anyone using Tjek from using version 8.
Version 8 comes with significant improvements to SwiftUI and Swift 6.
In this PR I've applied the minimal changes required to upgrade Kingfisher. This however includes bumping Tjek to a minimum iOS version of 13 up from 12.
Looking at the which devices that are unable to upgrade from iOS 12 I focused on iPhones where the iPhone 6 and older are unable to upgrade beyond iOS 12. This means that even the iPhone 6s is able to upgrade from 12 and all the way to 15. Of course I don't know the full scale of how many are running iOS 12 and who is still supporting iOS 12 but I think it's fair to suggest bumping this minimum requirement and maybe do so with a bump in Tjek's major version number, as to not accidentally break dependency resolutions that automatically pick this up.
While checking the library for any other warnings and errors I did notice that some things are deprecated in iOS 13 and warnings that will become an error in Swift 6 language mode. I left these things untouched since they are not part of the scope of this change.