Skip to content

Update Kingfisher #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Kingfisher #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d8d9d4
Update Kingfisher to 8.0.0
casperriboe Sep 26, 2025
7aeb687
Add MainActor requirement
casperriboe Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ let package = Package(
name: "TjekSDK",
defaultLocalization: "en",
platforms: [
.iOS(.v12),
.iOS(.v13),
.watchOS(.v6),
.macOS(.v10_14),
.tvOS(.v12)
Expand All @@ -19,7 +19,7 @@ let package = Package(
.package(name: "Incito", url: "https://github.com/tjek/incito-ios.git", from: "1.0.3"),
.package(name: "Future", url: "https://github.com/tjek/swift-future.git", from: "0.5.0"),
.package(name: "Verso", url: "https://github.com/tjek/verso-ios.git", from: "1.0.6"),
.package(name: "Kingfisher", url: "https://github.com/onevcat/Kingfisher.git", from: "7.0.0"),
.package(name: "Kingfisher", url: "https://github.com/onevcat/Kingfisher.git", from: "8.0.0"),
.package(name: "Valet", url: "https://github.com/square/Valet.git", from: "4.1.1")
],
targets: [
Expand Down
1 change: 1 addition & 0 deletions Sources/TjekPublicationViewer/PagedPublication/PagedPublicationView+ImageLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import UIKit

/// The object that knows how to load/cache the page images from a URL
/// Loosely based on `Kingfisher` interface
@MainActor
public protocol PagedPublicationViewImageLoader: AnyObject {
func loadImage(in imageView: UIImageView, url: URL, transition: (fadeDuration: TimeInterval, evenWhenCached: Bool), completion: @escaping ((Result<(image: UIImage, fromCache: Bool), Error>, URL) -> Void))
func cancelImageLoad(for imageView: UIImageView)
Expand Down