Convert signatures to keyword-only arguments#338
Convert signatures to keyword-only arguments#338ddelange wants to merge 1 commit intotkem:masterfrom
Conversation
| if isinstance(condition, bool): | ||
| from warnings import warn | ||
|
|
||
| warn( | ||
| "passing `info` as positional parameter is deprecated", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) | ||
| info = condition | ||
| condition = None |
There was a problem hiding this comment.
this is the typical type of bug that becomes impossible to make with keyword-only arguments
f862218 to
9f4d99d
Compare
9a090f2 to
41e3fc4
Compare
|
This PR is green now on my fork 👍 |
|
Hi @tkem 👋 This is ready for review |
|
@ddelange: Thanks for your interest! Without - i have to admit - looking too deeply into your submissions:
So, could you just refactor and make a seperate PR for the "dummy_threading" stuff? Would be appreciated! |
Because it is the oldest officially supported Python version: |
would it be an option to set a lock enabled by default en info disabled by default on the |
although this is true, setup-python still supports 3.7. i would recommend to either bump setup.cfg to 3.9+, or include 3.7 in CI to avoid unwelcome surprises |
Hi @tkem 👋
Hoping this PR can land in v6 🤞
This PR:
condition,lock,infoconfigurable for thecachetools.funcmodule.info=Truedefault toinfo=Falsedefault analogous to the main module.dummy_threadingwhich has been unavailable since 3.7 (the minimum required version of cachetools in setup.cfg).