Fix testunit CI hang by requiring test-unit >= 3.7.4 #139
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 8, 2026
| source 'https://rubygems.org' | ||
|
|
||
| gem 'test-unit' | ||
| gem 'test-unit', '>= 3.7.4' |
Collaborator
There was a problem hiding this comment.
Can you add a brief source code comment explaining the reason? For example:
Suggested change
| gem 'test-unit', '>= 3.7.4' | |
| # test-unit 3.7.4 changed `TestSuite#run` method signature. | |
| # Earlier versions cause ArgumentError in test-queue's TestSuite subclass, | |
| # crashing workers and causing the master process to hang indefinitely. | |
| gem 'test-unit', '>= 3.7.4' |
Contributor
Author
There was a problem hiding this comment.
Thanks for your review.
I've added a comment explaining why the test-unit version was selected.
The 3.3 testunit CI job was hanging for 6 hours and timing out. Problem: test-unit 3.7.4 changed the TestSuite#run method signature: - 3.7.3: run(result, run_context: nil, &block) - 3.7.4+: run(worker_context, &block) test-queue's TestSuite subclass uses `def run(*); super; end`, which fails on 3.7.3 when test-unit internally calls run with 2 arguments: ArgumentError: wrong number of arguments (given 2, expected 1) The worker process crashes, but the master process keeps waiting indefinitely, causing the hang. Reproduction: Hangs (with test-unit 3.7.3): gem install test-unit -v 3.7.3 BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb Works (with test-unit >= 3.7.4): gem install test-unit -v 3.7.5 BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb Solution: Pin test-unit to >= 3.7.4 in gemfiles/testunit.gemfile.
S-H-GAMELINKS
force-pushed
the
fix-testunit-ci-hang
branch
from
a511b61 to
4c210d0
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.3 testunit CI job was hanging for 6 hours and timing out.
Problem
test-unit 3.7.4 changed the TestSuite#run method signature
test-queue's TestSuite subclass uses
def run(*); super; end, which fails on 3.7.3 when test-unit internally calls run with 2 arguments:The worker process crashes, but the master process keeps waiting indefinitely, causing the hang.
Reproduction
Solution
Pin test-unit to >= 3.7.4 in gemfiles/testunit.gemfile.