Skip to content

Fix testunit CI hang by requiring test-unit >= 3.7.4 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koic merged 1 commit into from
Jan 9, 2026
Merged

Fix testunit CI hang by requiring test-unit >= 3.7.4 #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gemfiles/testunit.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

source 'https://rubygems.org'

gem 'test-unit'
# test-unit 3.7.4 changed `TestSuite#run` method signature.
# Earlier versions cause ArgumentError in test-queue's TestSuite subclass,
# crashing workers and causing the master process to hang indefinitely.
gem 'test-unit', '>= 3.7.4'
Copy link
Collaborator

@koic koic Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief source code comment explaining the reason? For example:

Suggested change
gem 'test-unit', '>= 3.7.4'
# test-unit 3.7.4 changed `TestSuite#run` method signature.
# Earlier versions cause ArgumentError in test-queue's TestSuite subclass,
# crashing workers and causing the master process to hang indefinitely.
gem 'test-unit', '>= 3.7.4'

Copy link
Contributor Author

@S-H-GAMELINKS S-H-GAMELINKS Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.
I've added a comment explaining why the test-unit version was selected.


gemspec path: '../'