Improve how we use returncode_t vs statuscode_t.#536
Merged
Conversation
bradjc
force-pushed
the
statuscode-to-returncode
branch
from
15bff44 to
1aaf8fd
Compare
StatusCode only exists over the syscall interface. Once we are in libtock-c we only use ReturnCode. We need to make sure we use tock_status_to_returncode() on values passed over the syscall interface.
bradjc
force-pushed
the
statuscode-to-returncode
branch
from
1aaf8fd to
6f09b00
Compare
ppannuto
reviewed
Jul 25, 2025
Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com>
ppannuto
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusCode only exists over the syscall interface. Once we are in libtock-c we only use ReturnCode.
We need to make sure we use tock_status_to_returncode() on values passed over the syscall interface.