enable some more tests in Miri #7734
Open
+13
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
miri-tests
branch
2 times, most recently
from
94fc155 to
9587d78
Compare
Author
|
poll_fns failed... does this not use the latest nightly? EDIT: Ah, I found where I have to bump it. |
Darksonn
reviewed
Nov 13, 2025
| working-directory: tokio | ||
| env: | ||
| MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-strict-provenance -Zmiri-retag-fields | ||
| MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-strict-provenance |
Contributor
There was a problem hiding this comment.
You are removing the retag fields argument?
Author
There was a problem hiding this comment.
As explained in the commit message, -Zmiri-retag-fields is the default (and has been the default for a long time already): rust-lang/miri#2985.
RalfJung
commented
Nov 13, 2025
|
|
||
| #[cfg(not(miri))] | ||
| #[cfg(not(miri))] // takes a really long time with miri | ||
| mod task_combinations; |
Author
There was a problem hiding this comment.
Interestingly, there's cfg!(miri) logic inside this module, even though the module is disabled on Miri anyway...
Contributor
There was a problem hiding this comment.
I probably ran it under miri when I wrote the test.
ADD-SP
added
A-ci
ADD-SP
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll_fnshas been fixed.And as for that
runtime.rstest: when the main thread is done, Miri gives the other threads a chance to finish before reporting a leak. At least in local testing, that seems to be enough for this test.We can also remove the
-Zmiri-retag-fieldsflag; it has been the default for more than 2 years already.