-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
enable some more tests in Miri #7734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f19d68f
d333f1a
7028718
988bbaa
49e8fac
55ff152
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,7 +77,7 @@ cfg_not_loom! { | |
| mod inject; | ||
| mod queue; | ||
|
|
||
| #[cfg(not(miri))] | ||
| #[cfg(not(miri))] // takes a really long time with miri | ||
| mod task_combinations; | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly, there's
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I probably ran it under miri when I wrote the test. |
||
|
|
||
| #[cfg(miri)] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are removing the retag fields argument?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained in the commit message,
-Zmiri-retag-fieldsis the default (and has been the default for a long time already): rust-lang/miri#2985.