Deletion of old API, STR_NTRIPC_S, also needs modifications of rtkrcv.c and naviopt.cpp #638
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deletion of old API of STR_NTRIPC_S in stream.c and the renumbering in rtklib.h also need modifications of app/consapp/rtkrcv/rtkrcv.c and app/winapp/rtknavi/naviopt.cpp
The deletion of old API of STR_NTRIPC_S in src/stream.c and the renumbering in src/rtklib.h also need a modification in app/winapp/rtknavi/naviopt.cpp .
Update for recognition of such as BDS B2b. See https://gpspp.sakura.ne.jp/diary202306.htm#0620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The app rtkrcv with an input stream type of NTRIP client fails. The app RTKNAVI with NTRIP client stream type produces a configuration file with the undetermined stream type of 6.
Suggestion:
We need modifications in app/consapp/rtkrcv/rtkrcv.c and app/winapp/rtknavi/naviopt.cpp reflecting the old API deletion of STR_NTRIPC_S in src/stream.c and the API renumbering in src/rtklib.h .
Description:
The definitions of ISTOPT and OSTOPT in app/consapp/rtkrcv/rtkrcv.c and app/winapp/rtknavi/naviopt.cpp are used not only for the help message, but also for parsing the configuration file. The configuration is performed calling functions of searchopt(), loadopts(), and saveopts().
As partially mentioned in an issue #569 (comment) , we require updating ISTOPT and OSTOPT.
I also suggest moving the definitions of TIMOPT, CONOPT, FLGOPT, ISTOPT, OSTOPT, FMTOPT, NMEOPT, SOLOPT, and MSGOPT to rtklib.h for further maintenance.
I acknowledge your long efforts and I love RTKLIB.