perf: Skip storage writes for no-op transactions #492
Closed
+48
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only call storage -store in transact! when the tx report has non-empty :tx-data. This avoids unnecessary writes for idempotent/no-effect transactions while preserving TxReport contents and listener semantics.
|
Thanks! Merged and released 1.7.7 |
|
*1.7.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes storage behavior by skipping persistence when transactions produce no datoms. This avoids unnecessary I/O for empty transactions and operations that add redundant or retract non-existent facts.
Problem
Currently, when a connection is associated with
:storage,d/transact!always callsstorage/-store, even when the transaction's:tx-datais empty. This happens for:(d/transact! conn [])These no-op transactions trigger unnecessary storage writes, impacting performance in scenarios with many such transactions.
Solution
Modified
-transact!insrc/datascript/conn.cljcto check(seq datoms)before executing storage logic. Storage writes are now skipped when:tx-datais empty.Key points: