Skip to content

perf: Skip storage writes for no-op transactions #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+48 −15
Closed

perf: Skip storage writes for no-op transactions #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions src/datascript/conn.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,22 @@
(vreset! *report r)
(:db-after r))))
#?(:clj
(when-some [storage (storage/storage @conn)]
(let [{db :db-after
datoms :tx-data} @*report
settings (set/settings (:eavt db))
*atom (:atom conn)
tx-tail' (:tx-tail (swap! *atom update :tx-tail conj datoms))]
(if (> (transduce (map count) + 0 tx-tail') (:branching-factor settings))
;; overflow tail
(do
(storage/store-impl! db (storage/storage-adapter db) false)
(swap! *atom assoc
:tx-tail []
:db-last-stored db))
;; just update tail
(storage/store-tail db tx-tail')))))
(when-some [_ (storage/storage @conn)]
(let [{db :db-after
datoms :tx-data} @*report]
(when (seq datoms)
(let [settings (set/settings (:eavt db))
*atom (:atom conn)
tx-tail' (:tx-tail (swap! *atom update :tx-tail conj datoms))]
(if (> (transduce (map count) + 0 tx-tail') (:branching-factor settings))
;; overflow tail
(do
(storage/store-impl! db (storage/storage-adapter db) false)
(swap! *atom assoc
:tx-tail []
:db-last-stored db))
;; just update tail
(storage/store-tail db tx-tail')))))))
@*report))

(defn transact!
Expand Down
32 changes: 32 additions & 0 deletions test/datascript/test/storage.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,38 @@
(let [conn''' (d/restore-conn storage)]
(is (= @conn'' @conn''')))))))

(deftest test-noop-transactions
(testing "No-op transactions should not trigger storage writes"
(let [storage (make-storage {:stats true})
conn (d/create-conn {:name {:db/unique :db.unique/identity}}
{:storage storage})]

(testing "empty tx-data"
(reset-stats storage)
(let [report (d/transact! conn [])]
(is (empty? (:tx-data report)))
(is (empty? @(:*writes storage)))))

(let [report (d/transact! conn [[:db/add 1 :name "Alice"]])]
(is (seq (:tx-data report)))
(is (= 1 (count @(:*writes storage)))))

(testing "adding existing fact"
(reset-stats storage)
(let [report (d/transact! conn [[:db/add 1 :name "Alice"]])]
(is (empty? (:tx-data report)))
(is (empty? @(:*writes storage)))))

(let [report (d/transact! conn [[:db/retract 1 :name "Alice"]])]
(is (seq (:tx-data report)))
(is (= 1 (count @(:*writes storage)))))

(testing "retracting non-existing fact"
(reset-stats storage)
(let [report (d/transact! conn [[:db/retract 1 :name "Alice"]])]
(is (empty? (:tx-data report)))
(is (empty? @(:*writes storage))))))))

(defn stress-test [{:keys [time branching-factor ref-type]
:or {time 10000
branching-factor 32
Expand Down