Text input component added and redundant css removed #261#263
Open
roshan-budhathoki wants to merge 5 commits intodevfrom
Open
Text input component added and redundant css removed #261#263roshan-budhathoki wants to merge 5 commits intodevfrom
roshan-budhathoki wants to merge 5 commits intodevfrom
Conversation
roshan-budhathoki
requested review from
bcha92,
kbventures and
manvinderjit
as code owners
github-actions
bot
added
the
Frontend 💅
Deploying volunteer with
|
| Latest commit: |
a0a2ab3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea6118e9.volunteer-ekr.pages.dev |
| Branch Preview URL: | https://feat-roshan-refactor-text-in.volunteer-ekr.pages.dev |
roshan-budhathoki
changed the title
kbventures
reviewed
Sep 17, 2025
kbventures
reviewed
Sep 17, 2025
kbventures
reviewed
Sep 17, 2025
kbventures
requested changes
Sep 17, 2025
Contributor
kbventures
left a comment
kbventures
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I left some nodes that need to be actioned.
Collaborator
|
@roshan-budhathoki nitpick: please use conventional commit format for the commit messages. The voice used should be active voice and it should be imperative and not use past tense. The best way to write a commit message is this format when you apply this commit, it will "fix: resolve the spacing issue between password bar and error msg" |
bcha92
approved these changes
Dec 8, 2025
Collaborator
bcha92
left a comment
bcha92
left a comment
There was a problem hiding this comment.
I think this is good to go
Contributor
|
Re assigned @s1m0n1au |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It implements the reusable input component in the Sign Up form.