Skip to content

Text input component added and redundant css removed #261 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roshan-budhathoki wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Text input component added and redundant css removed #261 #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26f58b6
text input component added and redundant css removed
roshan-budhathoki Sep 11, 2025
a87cc75
formating file
roshan-budhathoki Sep 11, 2025
0e6a7f2
fixed: spacing issue on password, helpermessagecomponent usage
roshan-budhathoki Sep 16, 2025
521f51c
formatting file
roshan-budhathoki Sep 16, 2025
a0a2ab3
update: change on error-color, line-height, font-size
roshan-budhathoki Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/HelperMessageComponent/HelperMessageComponent.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@

&[data-variant='success'] { span { color: var(--color-success); } }

&[data-variant='error'] { span { color: var(--color-error); } }
&[data-variant='error'] {
.helper-icon { color: var(--color-error); }
.helper-content { color: var(--color-error-text); }
}

&[data-variant='info'] { span { color: var(--color-info); } }

Expand All @@ -26,7 +29,8 @@
}

.helper-content {
font-size: 0.875rem;
font-size: var(--text-sm);
line-height: var(--leading-base);
font-style: normal;
font-weight: var(--weight-regular);
}
Expand Down
11 changes: 3 additions & 8 deletions src/components/SignUp/SignUpForm.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
border-radius: var(--rounded-md);
display: none;
font-size: var(--text-sm);
margin-top: 0.5rem;

p {
letter-spacing: 0%;
Expand All @@ -82,7 +83,6 @@

&.password-fail {
display: flex;
margin-top: 0.5rem;

&[data-password-fail=''] { display: none; }

Expand All @@ -107,13 +107,8 @@
}
}

#name-input-helper-text { display: none; }
#name-input:not(:focus):user-invalid ~ #name-input-helper-text { display: block; }
#name-input ~ .helper-container { display: none; }
#name-input:user-invalid:not(:focus) ~ .helper-container { display: flex; }

#email-input-helper-text { display: none; }
#email-input:not(:focus):user-invalid ~ #email-input-helper-text { display: block; }

.button-styling {
background: #ef343f;
color: white;
}
21 changes: 12 additions & 9 deletions src/components/SignUp/SignUpForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import './SignUpForm.css';
import { useRef, useState } from 'react';
import zxcvbn from 'zxcvbn';
import Button from '../Button/Button.tsx';
import HelperMessageComponent from '../HelperMessageComponent/HelperMessageComponent.tsx';
import TextInputComponent from '../TextInputComponent/TextInputComponent.tsx';

const strengthLabels = ['Weak', 'Fair', 'Good', 'Strong', 'Very Strong'];
const MIN_PASSWORD_SCORE = 3;
Expand Down Expand Up @@ -95,20 +97,21 @@ const SignUpForm = (): React.JSX.Element => {
<h2 className='center'>Welcome! Let's set up your account.</h2>
</div>
<div className='input-block'>
<label className='block' htmlFor='name-input'>Name</label>
<input
id='name-input'
type='text'
<TextInputComponent
label='Name'
name='name'
id='name-input'
placeholder='Your name'
minLength={1}
required
aria-describedby='name-input-helper-text'
helperMessageSlot={(
<HelperMessageComponent
variant='error'
labelText='Please enter a valid name that is at least 1 character long.'
/>
)}
ref={nameInputRef}
minLength={1}
/>
<div id='name-input-helper-text'>
<span>Please enter a valid name that is at least 1 character long.</span>
</div>
</div>

<div className='input-block'>
Expand Down
Loading