Reorganize src/ structure: group bootstrap concerns and move network utilities to testing

[Copilot]

Reorganize src/ structure: bootstrap and testing utilities ✅

Successfully reorganized the src/ directory structure to improve code organization and semantic clarity.

Changes Summary

1. Created src/bootstrap/ module - Groups application initialization concerns:

• app.rs - Application bootstrap and entry point logic
• container.rs - Dependency injection container (Services)
• help.rs - Help and usage information display
• logging.rs - Logging configuration and initialization
• mod.rs - Module exports

2. Created src/testing/network/ module - Network testing utilities:

• port_checker.rs - TCP port connectivity checking
• port_usage_checker.rs - Port usage validation
• mod.rs - Module exports

3. Updated all imports across 24 files:

• Binary executables (4 files)
• Library modules (6 files)
• Test infrastructure (6 files)
• Presentation layer (1 file)
• Documentation (2 files)
• Integration test (1 file)

4. Fixed doc test imports (latest commit):

• Updated all doc comments in bootstrap/logging.rs to use correct paths
• Updated doc comments in bootstrap/help.rs
• Updated doc comments in presentation/cli/args.rs

Benefits

✨ Clearer src/ root: Shows only main architectural layers (DDD + adapters + bootstrap + testing)
✨ Semantic accuracy: shared/ truly contains pure utilities, not infrastructure code
✨ Better discoverability: Related bootstrap concerns grouped together
✨ Honest organization: Test utilities in testing/, not pretending to be shared production code

Verification

• ✅ 200 doc tests pass - All documentation examples compile correctly
• ✅ 987 unit tests pass - All library tests successful
• ✅ No unused dependencies - cargo machete clean
• ✅ Clippy clean - No warnings or errors
• ✅ Build successful - Compilation passes
• ✅ Documentation updated - codebase-architecture.md reflects new structure

File Changes

26 files changed, 108 insertions(+), 59 deletions(-)

All acceptance criteria from the issue have been met. The refactoring is complete and all tests pass.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Reorganize src/ structure: group bootstrap concerns and move network utilities to testing</issue_title>
<issue_description>### 🎯 Motivation

The current src/ structure has some organizational inconsistencies:

1. Bootstrap concerns scattered in root: Files like app.rs, container.rs, logging.rs, and help.rs are bootstrap/initialization concerns that clutter the src/ root alongside the main DDD layers
2. Port checkers in wrong location: port_checker and port_usage_checker are in shared/ but they:
   • Are exclusively used in tests (not production code)
   • Perform infrastructure operations (network I/O)
   • Don't fit the semantic meaning of "shared utilities"

📋 Proposed Changes

1. Group Bootstrap Concerns in src/bootstrap/

Move application initialization and setup files into a dedicated bootstrap/ folder:

src/app.rs            → src/bootstrap/app.rs
src/container.rs      → src/bootstrap/container.rs
src/logging.rs        → src/bootstrap/logging.rs
src/help.rs           → src/bootstrap/help.rs

Rationale:

• Groups related concerns together (application lifecycle, DI container, logging setup, help display)
• Cleans up src/ root to show only the main architectural layers
• Name "bootstrap" is clear and won't be confused with tracker setup/deployment

2. Move Port Checkers to src/testing/network/

Move network testing utilities from shared to testing:

src/shared/port_checker.rs        → src/testing/network/port_checker.rs
src/shared/port_usage_checker.rs  → src/testing/network/port_usage_checker.rs

Rationale:

• These are test-only utilities (used exclusively in E2E and integration tests)
• They perform infrastructure operations (network checks), not pure utility functions
• Honest representation of their actual usage and purpose
• Can be moved to src/infrastructure/network/ later if needed in production

📊 Before and After

Current Structure:

src/
├── adapters/              ✅ Good
├── app.rs                ⚠️ Bootstrap concern
├── application/           ✅ DDD layer
├── bin/                  ✅ Standard location
├── config/               ✅ Configuration
├── container.rs          ⚠️ Bootstrap concern
├── domain/               ✅ DDD layer
├── help.rs               ⚠️ Bootstrap concern
├── infrastructure/        ✅ DDD layer
├── lib.rs                ✅ Library root
├── logging.rs            ⚠️ Bootstrap concern
├── main.rs               ✅ Entry point
├── presentation/          ✅ DDD layer
├── shared/               ⚠️ Mixing utilities with infrastructure
│   ├── clock.rs
│   ├── command/
│   ├── error/
│   ├── port_checker.rs   ❌ Test-only, infrastructure concern
│   ├── port_usage_checker.rs ❌ Test-only, infrastructure concern
│   └── username.rs
└── testing/              ✅ Test utilities

Proposed Structure:

src/
├── adapters/              ✅ External tool wrappers
├── application/           ✅ DDD layer
├── bin/                  ✅ Binary executables
├── bootstrap/            ✨ NEW: Application initialization
│   ├── app.rs
│   ├── container.rs
│   ├── help.rs
│   └── logging.rs
├── config/               ✅ Configuration
├── domain/               ✅ DDD layer
├── infrastructure/        ✅ DDD layer
├── lib.rs                ✅ Library root
├── main.rs               ✅ Entry point
├── presentation/          ✅ DDD layer
├── shared/               ✅ Pure utilities only
│   ├── clock.rs
│   ├── command/
│   ├── error/
│   └── username.rs
└── testing/              ✅ Test utilities
    ├── e2e/
    ├── fixtures.rs
    ├── integration/
    ├── mock_clock.rs
    └── network/          ✨ NEW: Network testing utilities
        ├── mod.rs
        ├── port_checker.rs
        └── port_usage_checker.rs

🔧 Migration Steps

1. Create new directories:

   • src/bootstrap/
   • src/testing/network/

2. Move bootstrap files:

   • Move app.rs, container.rs, help.rs, logging.rs to bootstrap/
   • Create src/bootstrap/mod.rs with appropriate exports

3. Move network utilities:

   • Move port_checker.rs and port_usage_checker.rs to testing/network/
   • Create src/testing/network/mod.rs with appropriate exports

4. Update imports throughout the codebase:

   • crate::app → crate::bootstrap::app
   • crate::container → crate::bootstrap::container
   • crate::logging → crate::bootstrap::logging
   • crate::help → crate::bootstrap::help
   • crate::shared::PortChecker → crate::testing::network::PortChecker
   • crate::shared::port_usage_checker::PortUsageChecker → crate::testing::network::PortUsageChecker

5. Update module exports in:

   • src/lib.rs (add bootstrap, update shared and testing exports)
   • src/shared/mod.rs (remove port checker exports)
   • src/testing/mod.rs (add network module)

6. Update documentation:

   • Update `docs/codebase-architecture.m...

• Fixes Reorganize src/ structure: group bootstrap concerns and move network utilities to testing #44

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[josecelano]

ACK 59b165f

[josecelano]

@copilot, the testing workflow is failing.

[Copilot]

@copilot, the testing workflow is failing.

Fixed in bf81f0f. The doc test failures were caused by outdated import paths in documentation examples. Updated all doc comments to use the new bootstrap:: module paths.

[josecelano]

ACK bf81f0f