Create shared test utilities module for command handlers

[Copilot]

Test utilities were duplicated across create/tests/fixtures.rs and inconsistently implemented in destroy/tests/. This created maintenance burden and inconsistent test patterns.

Changes

New shared test utilities (src/presentation/commands/tests/mod.rs):

• TestContext - Manages temporary directories with automatic cleanup
• create_valid_config() - Generates valid environment configurations
• create_invalid_json_config() - Creates malformed JSON for error testing
• create_config_with_invalid_name() - Invalid environment name for validation testing
• create_config_with_missing_keys() - Non-existent SSH keys for file validation testing

Test file updates:

• create/tests/integration.rs - 8 tests migrated to shared utilities
• create/tests/template.rs - 4 tests migrated to shared utilities
• destroy/tests/integration.rs - 5 tests migrated to shared utilities
• Removed duplicate create/tests/fixtures.rs (162 lines)

Usage

use crate::presentation::commands::tests::{TestContext, create_valid_config};

#[test]
fn it_should_create_environment_from_valid_config() {
    let context = TestContext::new();
    let config_path = create_valid_config(context.working_dir(), "test-env");
    
    let result = handle_environment_creation(&config_path, context.working_dir());
    assert!(result.is_ok());
    // Temp directory cleaned up automatically when context drops
}

Net reduction of ~190 lines with improved consistency across all command tests.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Create Shared Test Utilities Module</issue_title>
<issue_description>Parent Issue: #63
Type: 🔨 Structural Improvement
Impact: 🟢🟢 Medium
Effort: 🔵🔵 Medium
Priority: P1

Problem

Test utilities are duplicated and inconsistent:

• create/tests/ has comprehensive fixtures module
• destroy/tests/ lacks test helpers
• Common patterns like creating temp directories, generating test configs are repeated

Proposed Solution

Create shared test utilities at src/presentation/commands/tests/mod.rs:

//! Shared test utilities for command handlers

use std::path::{Path, PathBuf};
use std::sync::Arc;
use tempfile::TempDir;

/// Test context with temp directory and common test dependencies
pub struct TestContext {
    _temp_dir: TempDir,
    pub working_dir: PathBuf,
    pub repository: Arc<MockEnvironmentRepository>,
    pub clock: Arc<MockClock>,
}

impl TestContext {
    pub fn new() -> Self {
        let temp_dir = TempDir::new().expect("Failed to create temp directory");
        let working_dir = temp_dir.path().to_path_buf();
        
        let repository_factory = RepositoryFactory::new(std::time::Duration::from_secs(30));
        let repository = Arc::new(repository_factory.create(working_dir.clone()));
        
        let clock = Arc::new(MockClock::new(chrono::Utc::now()));
        
        Self { _temp_dir: temp_dir, working_dir, repository, clock }
    }
    
    pub fn working_dir(&self) -> &Path {
        &self.working_dir
    }
}

/// Create a valid test configuration file
pub fn create_test_config(path: &Path, env_name: &str) -> PathBuf {
    // Implementation
}

/// Create an invalid JSON configuration file for error testing
pub fn create_invalid_json_config(path: &Path) -> PathBuf {
    // Implementation
}

/// Create a configuration with invalid environment name
pub fn create_config_with_invalid_name(path: &Path) -> PathBuf {
    // Implementation
}

Then use in tests:

use crate::presentation::commands::tests::{TestContext, create_test_config};

#[test]
fn it_should_create_environment_from_valid_config() {
    let context = TestContext::new();
    let config_path = create_test_config(context.working_dir(), "test-env");
    
    let result = handle_environment_creation(&config_path, context.working_dir());
    assert!(result.is_ok());
}

Benefits

• ✅ Reduces test code duplication
• ✅ Consistent test patterns across commands
• ✅ Easier to write new tests
• ✅ Shared improvements benefit all tests

Implementation Checklist

• Create src/presentation/commands/tests/mod.rs
• Implement TestContext struct with temp dir management
• Migrate create_test_config() from fixtures.rs
• Migrate create_invalid_json_config() from fixtures.rs
• Migrate create_config_with_invalid_name() from fixtures.rs
• Add comprehensive documentation
• Update create/tests/ to use shared utilities
• Update destroy/tests/ to use shared utilities
• Remove duplicate code from old test files
• Verify all tests pass
• Run linter

Acceptance Criteria

• Shared test utilities module exists
• TestContext provides consistent test setup
• Common test config generators are shared
• Both create and destroy tests use shared utilities
• No duplicate test helper code remains
• All tests pass: cargo test presentation::commands
• Pre-commit checks pass: ./scripts/pre-commit.sh
• Code follows project conventions

Related Documentation

• Testing Guide
• Refactor Plan</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Create Shared Test Utilities Module #70

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[josecelano]

ACK 045f131