Skip to content

Conversation

@josecelano
Copy link
Member

@josecelano josecelano commented Jun 2, 2025

I will add a new metric to count which client's software is used when a UDP error is produced (only for connection ID errors, for now).

This PR make some changes before adding the new metric.

Subtasks

  • Wrapper for aquatic parse error. It's not sendable.
  • Add the error to the Event::UdpError event.
  • Move logic to increase the number of wrong connection IDs per IP to the event listener.
  • Rename errors.
  • Refactor event handler.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 94.80969% with 30 lines in your changes missing coverage. Please review.

Project coverage is 83.35%. Comparing base (059d2b6) to head (a8f3a97).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
packages/udp-tracker-server/src/event.rs 35.29% 11 Missing ⚠️
packages/udp-tracker-server/src/error.rs 78.26% 5 Missing ⚠️
...rver/src/statistics/event/handler/response_sent.rs 96.69% 4 Missing ⚠️
packages/udp-tracker-server/src/handlers/error.rs 92.30% 0 Missing and 2 partials ⚠️
...acker-server/src/statistics/event/handler/error.rs 95.91% 2 Missing ⚠️
...r/src/statistics/event/handler/request_received.rs 94.28% 2 Missing ⚠️
...tracker-server/src/statistics/event/handler/mod.rs 95.65% 0 Missing and 1 partial ⚠️
...er/src/statistics/event/handler/request_aborted.rs 98.18% 1 Missing ⚠️
...r/src/statistics/event/handler/request_accepted.rs 99.38% 1 Missing ⚠️
...ver/src/statistics/event/handler/request_banned.rs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1552    +/-   ##
=========================================
  Coverage    83.35%   83.35%            
=========================================
  Files          275      282     +7     
  Lines        19601    19728   +127     
  Branches     19601    19728   +127     
=========================================
+ Hits         16339    16445   +106     
- Misses        2962     2981    +19     
- Partials       300      302     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josecelano josecelano marked this pull request as ready for review June 2, 2025 18:07
@josecelano
Copy link
Member Author

ACK a8f3a97

@josecelano josecelano merged commit 578057b into torrust:develop Jun 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Cleanup / Refactoring Tidying and Making Neat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overhaul stats: Refactor logic related to UDP errors

1 participant