-
Notifications
You must be signed in to change notification settings - Fork 49
Refactor UDP error event logic before adding new metrics #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josecelano
merged 11 commits into
torrust:develop
from
josecelano:1551-overhaul-stats-refactor-logic-related-to-udp-errors
Jun 2, 2025
Merged
Refactor UDP error event logic before adding new metrics #1552
josecelano
merged 11 commits into
torrust:develop
from
josecelano:1551-overhaul-stats-refactor-logic-related-to-udp-errors
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t sendable The error will be included in the UdpError event ans sent via tokio channel.
Not exposing the original complex error type becuase: - It's too complex. - It forces all errors to be "Sent", "PartialEq". - It would expose a lot of internals.
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1552 +/- ##
=========================================
Coverage 83.35% 83.35%
=========================================
Files 275 282 +7
Lines 19601 19728 +127
Branches 19601 19728 +127
=========================================
+ Hits 16339 16445 +106
- Misses 2962 2981 +19
- Partials 300 302 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
ACK a8f3a97 |
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add a new metric to count which client's software is used when a UDP error is produced (only for connection ID errors, for now).
This PR make some changes before adding the new metric.
Subtasks
Event::UdpErrorevent.