Skip to content

Refactor UDP error event logic before adding new metrics #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josecelano merged 11 commits into from
Jun 2, 2025

refactor: [#1551] extract event handler for each udp event

a8f3a97
Select commit
Loading
Failed to load commit list.
Merged

Refactor UDP error event logic before adding new metrics #1552

refactor: [#1551] extract event handler for each udp event
a8f3a97
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 2, 2025 in 1s

83.35% (+0.00%) compared to 059d2b6

View this Pull Request on Codecov

83.35% (+0.00%) compared to 059d2b6

Details

Codecov Report

Attention: Patch coverage is 94.80969% with 30 lines in your changes missing coverage. Please review.

Project coverage is 83.35%. Comparing base (059d2b6) to head (a8f3a97).

Files with missing lines Patch % Lines
packages/udp-tracker-server/src/event.rs 35.29% 11 Missing ⚠️
packages/udp-tracker-server/src/error.rs 78.26% 5 Missing ⚠️
...rver/src/statistics/event/handler/response_sent.rs 96.69% 4 Missing ⚠️
packages/udp-tracker-server/src/handlers/error.rs 92.30% 0 Missing and 2 partials ⚠️
...acker-server/src/statistics/event/handler/error.rs 95.91% 2 Missing ⚠️
...r/src/statistics/event/handler/request_received.rs 94.28% 2 Missing ⚠️
...tracker-server/src/statistics/event/handler/mod.rs 95.65% 0 Missing and 1 partial ⚠️
...er/src/statistics/event/handler/request_aborted.rs 98.18% 1 Missing ⚠️
...r/src/statistics/event/handler/request_accepted.rs 99.38% 1 Missing ⚠️
...ver/src/statistics/event/handler/request_banned.rs 98.18% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop    #1552    +/-   ##
=========================================
  Coverage    83.35%   83.35%            
=========================================
  Files          275      282     +7     
  Lines        19601    19728   +127     
  Branches     19601    19728   +127     
=========================================
+ Hits         16339    16445   +106     
- Misses        2962     2981    +19     
- Partials       300      302     +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov