chore: update deps #39
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| >=18.x No newline at end of file | |||
| >=24.x No newline at end of file | |||
There was a problem hiding this comment.
Node.js version mismatch between .nvmrc and CI/package.json
Medium Severity
The .nvmrc file requires >=24.x but the CI workflows test with Node.js 22.x, and package.json engines specify >=22.x. This version mismatch means developers using nvm locally will use Node.js 24+, but CI only validates against Node.js 22. Code working on Node.js 24 could break on 22, and CI wouldn't catch it. The .nvmrc, package.json engines, and CI matrix versions need to be aligned.
Additional Locations (2)
| run: npx playwright install | ||
|
|
||
| - name: Run tests | ||
| run: npm run test |
There was a problem hiding this comment.
Duplicated workflow files could be consolidated
Low Severity
The ci.yml and master.yml workflow files are nearly identical (30+ lines duplicated), differing only in their branch trigger conditions. This could be a single workflow file using on: push without branch restrictions, which would run on all branches including master. The duplication increases maintenance burden and risks inconsistent updates if one file is modified without the other.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Low Risk
Low-risk CI/config-only changes, but Node version expectations may drift because CI runs Node 22 while
.nvmrcnow requests >=24.Overview
Adds CI test automation via GitHub Actions. Introduces two workflows:
ci.ymlrunsnpm run teston non-masterpushes andmaster.ymlruns the same suite onmaster, including Playwright dependency/browser installation.Updates local Node version hint. Changes
.nvmrcfrom>=18.xto>=24.x(while the workflows use Node22.x).Written by Cursor Bugbot for commit 9b55d9c. This will update automatically on new commits. Configure here.