Skip to content

chore: update deps #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hieu-w wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: update deps #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a690eb
chore: update deps
hieu-w Jan 30, 2026
9b55d9c
fix: add test and ci
hieu-w Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
on:
push:
branches-ignore:
- "master"

name: Run Tests

jobs:
test:
name: run tests
strategy:
matrix:
node: ["22.x"]
os: [ubuntu-latest]

runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: "npm"

- name: Install dependencies
run: npm install

- name: Install playwright webkit
run: npx playwright install-deps webkit

- name: Install browsers
run: npx playwright install

- name: Run tests
run: npm run test
Copy link

@cursor cursor bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated workflow files could be consolidated

Low Severity

The ci.yml and master.yml workflow files are nearly identical (30+ lines duplicated), differing only in their branch trigger conditions. This could be a single workflow file using on: push without branch restrictions, which would run on all branches including master. The duplication increases maintenance burden and risks inconsistent updates if one file is modified without the other.

Additional Locations (1)

Fix in Cursor Fix in Web

36 changes: 36 additions & 0 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
on:
push:
branches: [master]

name: Run Tests

jobs:
test:
name: run tests
strategy:
matrix:
node: ["22.x"]
os: [ubuntu-latest]

runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: "npm"

- name: Install dependencies
run: npm install

- name: Install playwright webkit
run: npx playwright install-deps webkit

- name: Install browsers
run: npx playwright install

- name: Run tests
run: npm run test
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
>=18.x
>=24.x
Copy link

@cursor cursor bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js version mismatch between .nvmrc and CI/package.json

Medium Severity

The .nvmrc file requires >=24.x but the CI workflows test with Node.js 22.x, and package.json engines specify >=22.x. This version mismatch means developers using nvm locally will use Node.js 24+, but CI only validates against Node.js 22. Code working on Node.js 24 could break on 22, and CI wouldn't catch it. The .nvmrc, package.json engines, and CI matrix versions need to be aligned.

Additional Locations (2)

Fix in Cursor Fix in Web

Loading
Loading