You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given how flow has been implemented and that design principles outlined in the CONTRIBUTING.md file highlight simplicity as one of the core values of the project, I'd say such type magic might be too much.
The way it's set up in this PR now makes pipe support strict typing for up to 8 functions passed to it and falls back to being any-typed after, which I would argue is a decent deal, as I think it would fit the vast majority of use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
pipefunction, as requested in the current second most upvoted issue (#1187).Added:
pipefunction implementationpipetests (including type-level)pipedocs (note: I do not know Korean, Japanese or Chinese and used an LLM to translate the English ones, which I wrote myself)pipeperformance benchmark (I did not add the bundle size one as I reckoned only the utilities that have a Lodash equivalent needed it)Here is the screenshot of the performance benchmark results:
