update createDefaultCodec to handle Unknown types correctly#35
Open
abrantesarthur wants to merge 3 commits intomainfrom
Open
update createDefaultCodec to handle Unknown types correctly#35abrantesarthur wants to merge 3 commits intomainfrom
abrantesarthur wants to merge 3 commits intomainfrom
Conversation
abrantesarthur
changed the title
dipack95
reviewed
Jan 19, 2025
|
|
||
| // The default of an object type is an empty object | ||
| if (codec instanceof t.ObjectType) { | ||
| if (codec instanceof t.ObjectType || codec instanceof t.UnknownType) { |
Member
There was a problem hiding this comment.
I think this needs to be UnknownRecord, since UnknownType is for unknown
Contributor
Author
There was a problem hiding this comment.
Interestingly, if I do codec instanceof t.RecordType I get error Right-hand side of 'instanceof' is not callable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]