Conversation
vkatsuba
left a comment
There was a problem hiding this comment.
Could you please add call of dialyzer to CI? Maybe it also will be need to update a specs for dialyzer in rebar config file - for better check.
|
Also you can run CI in your fork workflow - after updates - please, provide a link to CI status. |
|
WOrking on it.. the fixes I did are limited to the code I use, and bring down from 101 to 89 dialyzer warnings afaik.. I'm adding a CI check to verify no one adds more to it at least.. since I can't fix all 89 atm :) |
3ee92f6 to
e55cf62
Compare
|
https://github.com/riccardomanfrin/eradius/actions/runs/11052468755 This is the link to the CI run, I added dialyzer check step, and allowed for the current existing warnings to pass which in github CI are 103. Let me know it it works for you |
|
@0xAX, @RoadRunnr, @ebengt could you please take a look to those changes? |
Ciao,
I'm trying to use the library but it's giving me dialyzer problems.. would be nice to keep using your repo.
let me know
Thanks