Skip to content

Fixup dialyzer #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riccardomanfrin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixup dialyzer #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40e7c63
Fixup dialyzer
Sep 26, 2024
e55cf62
CI to check dialyzer
Sep 26, 2024
32ec4c4
Adapt to github CI
Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ jobs:
uses: actions/checkout@v3
- name: Build
run: rebar3 compile
- name: Dialyzer
run: |
rebar3 dialyzer || true
WARNINGS=$(cat _build/default/*.dialyzer_warnings | grep -e '^$' | wc -l)
if [ ${WARNINGS} -gt 103 ]; then exit -1; fi
- name: Run tests
run: |
rebar3 do xref, ct
Expand Down
2 changes: 1 addition & 1 deletion include/eradius_lib.hrl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
-type atom_name() :: atom().
-type atom_ip() :: atom().
-type atom_port() :: atom().
-type atom_address() :: {atom_name(), {atom_ip(), atom_port()}}.
-type atom_address() :: {atom_name(), atom_ip(), atom_port()}.
-type atom_address_pair() :: {atom_address(), atom_address()}.

%%- cmds
Expand Down
10 changes: 5 additions & 5 deletions src/eradius_lib.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ decode_request_id(_Req) -> {bad_pdu, "invalid request id"}.
decode_request(Packet, Secret) ->
decode_request(Packet, Secret, undefined).

-spec decode_request(binary(), secret(), authenticator()) -> #radius_request{} | {bad_pdu, list()}.
-spec decode_request(binary(), secret(), authenticator() | undefined) -> #radius_request{} | {bad_pdu, list()}.
decode_request(Packet, Secret, Authenticator) ->
case (catch decode_request0(Packet, Secret, Authenticator)) of
{'EXIT', _} -> {bad_pdu, "decode packet error"};
Expand Down Expand Up @@ -261,13 +261,13 @@ decode_request0(<<Cmd:8, ReqId:8, Len:16, PacketAuthenticator:16/binary, Body0/b
true -> Request
end.

-spec validate_packet_authenticator(non_neg_integer(), non_neg_integer(), non_neg_integer(), non_neg_integer(), binary(), binary(), authenticator(), authenticator() | 'undefined') -> ok.
-spec validate_packet_authenticator(non_neg_integer(), non_neg_integer(), non_neg_integer(), binary(), non_neg_integer(), binary(), authenticator(), authenticator() | 'undefined') -> ok.
validate_packet_authenticator(Cmd, ReqId, Len, Body, Pos, Secret, PacketAuthenticator, undefined) ->
validate_packet_authenticator(Cmd, ReqId, Len, PacketAuthenticator, Body, Pos, Secret);
validate_packet_authenticator(Cmd, ReqId, Len, Body, Pos, Secret, _PacketAuthenticator, RequestAuthenticator) ->
validate_packet_authenticator(Cmd, ReqId, Len, RequestAuthenticator, Body, Pos, Secret).

-spec validate_packet_authenticator(non_neg_integer(), non_neg_integer(), non_neg_integer(), authenticator(), non_neg_integer(), binary(), binary()) -> ok.
-spec validate_packet_authenticator(non_neg_integer(), non_neg_integer(), non_neg_integer(), authenticator(), binary(), non_neg_integer(), binary()) -> ok.
validate_packet_authenticator(Cmd, ReqId, Len, Auth, Body, Pos, Secret) ->
case Body of
<<Before:Pos/bytes, Value:16/bytes, After/binary>> ->
Expand Down Expand Up @@ -321,7 +321,7 @@ decode_command(_) -> error({bad_pdu, "unknown request type"}
append_attr(Attr, State) ->
State#decoder_state{attrs = [Attr | State#decoder_state.attrs]}.

-spec decode_attributes(#radius_request{}, binary(), binary()) -> #decoder_state{}.
-spec decode_attributes(#radius_request{}, undefined | binary(), binary()) -> #decoder_state{}.
decode_attributes(Req, RequestAuthenticator, As) ->
decode_attributes(Req, As, 0, #decoder_state{request_authenticator = RequestAuthenticator}).

Expand Down Expand Up @@ -508,7 +508,7 @@ pad_to(Width, Binary) ->
N -> <<Binary/binary, 0:(N*8)>>
end.

-spec timestamp() -> erlang:timestamp().
-spec timestamp() -> integer().
timestamp() ->
erlang:system_time(milli_seconds).

Expand Down