Skip to content

refactor: rework the proxy engine cache read/write to add concurrency limits#900

Merged
crandles merged 1 commit intotrickstercache:mainfrom
crandles:proxy-engine-refactor
Dec 16, 2025
Merged

refactor: rework the proxy engine cache read/write to add concurrency limits#900
crandles merged 1 commit intotrickstercache:mainfrom
crandles:proxy-engine-refactor

Conversation

@crandles
Copy link
Contributor

@crandles crandles commented Dec 15, 2025

  • Adds a limit to concurrent cache chunk operations from single read/write
    • Previously, there was no limit
  • Adds early exit to concurrent cache chunk operations, on first error
    • Previously, the cache operations would wait for all chunks to complete before failing the overall request

… limits

Signed-off-by: Chris Randles <randles.chris@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20218791324

Details

  • 268 of 316 (84.81%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/proxy/engines/cache.go 14 16 87.5%
pkg/proxy/engines/cache_write.go 99 111 89.19%
pkg/proxy/engines/cache_read.go 153 187 81.82%
Files with Coverage Reduction New Missed Lines %
pkg/proxy/engines/cache.go 2 92.37%
Totals Coverage Status
Change from base Build 20187279647: 0.03%
Covered Lines: 14789
Relevant Lines: 20586

💛 - Coveralls

@crandles crandles marked this pull request as ready for review December 15, 2025 21:42
@crandles crandles requested a review from a team as a code owner December 15, 2025 21:42
@crandles crandles merged commit f81ab51 into trickstercache:main Dec 16, 2025
7 checks passed
@crandles crandles deleted the proxy-engine-refactor branch December 16, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants