Skip to content

refactor: rework the proxy engine cache read/write to add concurrency limits #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crandles merged 1 commit into from
Dec 16, 2025
Merged

refactor: rework the proxy engine cache read/write to add concurrency limits #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/backends/options/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ const (
DefaultTimeseriesShardSize = 0
// DefaultTimeseriesShardStep defines the default shard step of 0 (no sharding)
DefaultTimeseriesShardStep = 0
// DefaultChunkReadConcurrencyLimit defines the default chunk read concurrency limit
DefaultChunkReadConcurrencyLimit = 16
// DefaultChunkReadConcurrencyLimit defines the default chunk write concurrency limit
DefaultChunkWriteConcurrencyLimit = 16
)

// DefaultCompressibleTypes returns a list of types that Trickster should compress before caching
Expand Down
6 changes: 6 additions & 0 deletions pkg/backends/options/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ type Options struct {
CacheName string `yaml:"cache_name,omitempty"`
// CacheKeyPrefix defines the cache key prefix the backend will use when writing objects to the cache
CacheKeyPrefix string `yaml:"cache_key_prefix,omitempty"`
// ChunkReadConcurrencyLimit defines the concurrency limit while reading a chunked object
ChunkReadConcurrencyLimit int `yaml:"chunk_read_concurrency_limit,omitempty"`
// ChunkWriteConcurrencyLimit defines the concurrency limit while writing a chunked object
ChunkWriteConcurrencyLimit int `yaml:"chunk_write_concurrency_limit,omitempty"`
// HealthCheck is the health check options reference for this backend
HealthCheck *ho.Options `yaml:"healthcheck,omitempty"`
// Object Proxy Cache and Delta Proxy Cache Configurations
Expand Down Expand Up @@ -226,6 +230,8 @@ func New() *Options {
CacheKeyPrefix: "",
CacheName: DefaultBackendCacheName,
CompressibleTypeList: DefaultCompressibleTypes(),
ChunkReadConcurrencyLimit: DefaultChunkReadConcurrencyLimit,
ChunkWriteConcurrencyLimit: DefaultChunkWriteConcurrencyLimit,
FastForwardTTL: DefaultFastForwardTTL,
ForwardedHeaders: DefaultForwardedHeaders,
HealthCheck: ho.New(),
Expand Down
14 changes: 14 additions & 0 deletions pkg/config/testdata/example.alb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down Expand Up @@ -37,6 +39,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck:
interval: 1s
path: /health
Expand Down Expand Up @@ -70,6 +74,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck:
interval: 1s
path: /health
Expand Down Expand Up @@ -103,6 +109,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck:
interval: 1s
timeseries_retention_factor: 1024
Expand Down Expand Up @@ -135,6 +143,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck:
interval: 1s
timeseries_retention_factor: 1024
Expand Down Expand Up @@ -166,6 +176,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down Expand Up @@ -201,6 +213,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
8 changes: 8 additions & 0 deletions pkg/config/testdata/example.auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down Expand Up @@ -40,6 +42,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down Expand Up @@ -72,6 +76,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down Expand Up @@ -102,6 +108,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
2 changes: 2 additions & 0 deletions pkg/config/testdata/example.full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
2 changes: 2 additions & 0 deletions pkg/config/testdata/exmple.sharding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
2 changes: 2 additions & 0 deletions pkg/config/testdata/simple.prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
2 changes: 2 additions & 0 deletions pkg/config/testdata/simple.reverseproxycache.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ backends:
keep_alive_timeout: 5m0s
max_idle_conns: 20
cache_name: default
chunk_read_concurrency_limit: 16
chunk_write_concurrency_limit: 16
healthcheck: {}
timeseries_retention_factor: 1024
timeseries_eviction_method: oldest
Expand Down
Loading
Loading