-
-
Notifications
You must be signed in to change notification settings - Fork 964
Use rawAttributes to preserve original date strings in log details #2892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rawAttributes to preserve original date strings in log details #2892
Conversation
Fixed documentation examples to use correct 'data' field instead of 'output' for the waitpoint token completion endpoint. The API schema expects 'data' in the request body, but all code examples (curl, Python, Ruby, Go) incorrectly showed 'output', causing waitpoints to complete with empty/undefined output when users followed the docs. Fixes triggerdotdev#2872
This prevents the logger from reformatting date-like strings (e.g., "Tuesday...") into ISO format. We now prioritize rawAttributes from the backend to bypass superjson's automatic date transformation, ensuring the UI displays exactly what was logged.
|
WalkthroughThis change adds support for a new Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Closes #2882
✅ Checklist
Testing
[Describe the steps you took to test this change]
I have performed all the tests locally, found no issue.
Changelog
I found that trigger backend is using
@remix-typedjson which serializes the string into date object and sends it to the frontend
I have created a frontend fix , which takes the string rawAttributes which is returned by the server response instead of attributes which are serialized by the typedjson to preserve the original user payload.
Related files:
Review lines: 71-105
https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/presenters/v3/LogDetailPresenter.server.ts
Review Lines: 44-59
https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/routes/resources.orgs.%24organizationSlug.projects.%24projectParam.env.%24envParam.logs.%24logId.tsx
Screenshots
The screenshot shows the original issue, which automatically converts string into a date object.


💯