Skip to content

Conversation

@ShivaReddyVanja
Copy link
Contributor

Closes #2882

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

[Describe the steps you took to test this change]
I have performed all the tests locally, found no issue.

Changelog

I found that trigger backend is using
@remix-typedjson which serializes the string into date object and sends it to the frontend

I have created a frontend fix , which takes the string rawAttributes which is returned by the server response instead of attributes which are serialized by the typedjson to preserve the original user payload.

Related files:
Review lines: 71-105
https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/presenters/v3/LogDetailPresenter.server.ts
Review Lines: 44-59
https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/routes/resources.orgs.%24organizationSlug.projects.%24projectParam.env.%24envParam.logs.%24logId.tsx


Screenshots

The screenshot shows the original issue, which automatically converts string into a date object.
Screenshot 2026-01-15 at 1 39 55 PM
Screenshot 2026-01-15 at 3 46 51 PM

💯

appdevelopers9a and others added 3 commits January 14, 2026 23:10
Fixed documentation examples to use correct 'data' field instead of
'output' for the waitpoint token completion endpoint.

The API schema expects 'data' in the request body, but all code examples
(curl, Python, Ruby, Go) incorrectly showed 'output', causing waitpoints
to complete with empty/undefined output when users followed the docs.

Fixes triggerdotdev#2872
This prevents the logger from reformatting date-like strings (e.g., "Tuesday...") into ISO format.
We now prioritize rawAttributes from the backend to bypass superjson's automatic date transformation,
ensuring the UI displays exactly what was logged.
@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

⚠️ No Changeset found

Latest commit: 3d4ede2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Walkthrough

This change adds support for a new rawAttributes field on log entries in the LogDetailView component. When present, the field is parsed as JSON and pretty-printed with indentation and additional JSON formatting. If parsing fails, the raw string value is used as a fallback. When rawAttributes is absent, the component falls back to the existing attributes-based formatting. A temporary local type augmentation accommodates the new field without modifying public types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the key points: issue closure, problem identification, root cause analysis, solution approach, and testing. While slightly informal, it adequately documents the change and references related files for review.
Linked Issues check ✅ Passed The PR successfully addresses issue #2882 by implementing the rawAttributes field to preserve original date-like strings, preventing automatic date transformation that was occurring with typedjson serialization.
Out of Scope Changes check ✅ Passed The changes are narrowly scoped to adding rawAttributes field support in LogDetailView.tsx with appropriate fallback logic, directly addressing the linked issue #2882 without introducing unrelated modifications.
Title check ✅ Passed The title accurately describes the main change: using rawAttributes to preserve original date strings in log details, which directly addresses the PR's core objective of preventing unintended date reformatting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShivaReddyVanja ShivaReddyVanja changed the title Fix/log date formatting when using the logger Use rawAttributes to preserve original date strings in log details Jan 15, 2026
@ericallam ericallam closed this Jan 15, 2026
@vibe-kanban-cloud
Copy link

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

@ShivaReddyVanja ShivaReddyVanja deleted the fix/log-date-formatting branch January 15, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Logger unexpectedly formats date-like strings in payloads

3 participants