Skip to content

Use rawAttributes to preserve original date strings in log details #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShivaReddyVanja wants to merge 4 commits into from
+14 −1
Closed

Use rawAttributes to preserve original date strings in log details #2892

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d36d20
docs: fix waitpoint token completion request body field
appdevelopers9a Jan 14, 2026
046af66
fix(webapp): prevent date string reformatting in log details
ShivaReddyVanja Jan 15, 2026
621398f
Merge branch 'triggerdotdev:main' into fix/log-date-formatting
ShivaReddyVanja Jan 15, 2026
3d4ede2
Merge branch 'main' into fix/log-date-formatting
ShivaReddyVanja Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/webapp/app/components/logs/LogDetailView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,25 @@ export function LogDetailView({ logId, initialLog, onClose, searchTerm }: LogDet
function DetailsTab({ log, runPath, searchTerm }: { log: LogEntry; runPath: string; searchTerm?: string }) {
const logWithExtras = log as LogEntry & {
attributes?: LogAttributes;
rawAttributes?: string;
};


let beautifiedAttributes: string | null = null;

if (logWithExtras.attributes) {
if (logWithExtras.rawAttributes) {
try {
// It's a string, so we need to parse it first to be able to re-stringify it with indentation
const parsed = JSON.parse(logWithExtras.rawAttributes);
beautifiedAttributes = JSON.stringify(parsed, null, 2);
} catch (e) {
beautifiedAttributes = logWithExtras.rawAttributes;
}
// We already have the raw string, so we don't need to format it again
if (beautifiedAttributes) {
beautifiedAttributes = formatStringJSON(beautifiedAttributes);
}
} else if (logWithExtras.attributes) {
beautifiedAttributes = JSON.stringify(logWithExtras.attributes, null, 2);
beautifiedAttributes = formatStringJSON(beautifiedAttributes);
}
Expand Down