Optimize Zstd decompression to reduce memory allocations and improve performance#149
Merged
nineinchnick merged 1 commit intotrinodb:masterfrom Nov 30, 2025
Merged
Conversation
Member
|
@Flgado can you rebase? I think we can merge this |
nineinchnick
approved these changes
Nov 25, 2025
Member
Author
|
Sure @nineinchnick ! lets just first try to merge the #144 :) |
Member
|
Rebase and we can merge it now |
f4f445a to
da21e65
Compare
Member
Author
|
@nineinchnick done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change optimizes the Zstd decompression logic by switching from io.ReadAll(zstd.NewReader(bytes.NewReader(data))) to using zstd.Decoder.DecodeAll with a pre-allocated buffer.
Motivation
The old approach creates a new bytes.Reader and reads all decompressed data into a freshly allocated buffer, causing many heap allocations and increased GC pressure.
Impact
This significantly improves memory efficiency, especially important for large result sets.
Benchmarks Example:
The major impact was on io.Read allocation.