Skip to content

Optimize Zstd decompression to reduce memory allocations and improve performance #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize Zstd decompression to reduce memory allocations and improve performance #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions trino/trino.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,12 +1695,13 @@ func decompressSegment(data []byte, encoding string, metadata segmentMetadata) (
var decompressedData []byte
switch encoding {
case "json+zstd":
zstdReader, err := zstd.NewReader(bytes.NewReader(data))
zstdDecoder, err := zstd.NewReader(nil)
if err != nil {
return nil, fmt.Errorf("error creating zstd reader: %w", err)
}
defer zstdReader.Close()
decompressedData, err = io.ReadAll(zstdReader)
defer zstdDecoder.Close()
dst := make([]byte, 0, metadata.uncompressedSize)
decompressedData, err = zstdDecoder.DecodeAll(data, dst)
if err != nil {
return nil, fmt.Errorf("failed to decompress zstd segment at rowOffset %d: %v", metadata.rowOffset, err)
}
Expand Down
Loading