-
Notifications
You must be signed in to change notification settings - Fork 3
WIP: Add non-conservative 2D Euler equations with gravity potential #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amrueda
wants to merge
15
commits into
main
Choose a base branch
from
arr/euler_gravity_geopotential
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
===========================================
- Coverage 90.68% 80.51% -10.17%
===========================================
Files 22 23 +1
Lines 2189 2663 +474
===========================================
+ Hits 1985 2144 +159
- Misses 204 519 +315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Benedict Geihe <[email protected]>
e5b5534 to
57ebc3b
Compare
…mework/TrixiAtmo.jl into arr/euler_gravity_geopotential
…mework/TrixiAtmo.jl into arr/euler_gravity_geopotential
2 tasks
Member
|
@amrueda What still needs to be done for this PR to be ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of equations extends the
CompressibleEulerEquations2Dby incorporating geopotential energy into the total energyrho_e. This ensures that the energy equation remains a conservation law, even in the presence of gravitational effects. Additionally, the source terms in the momentum equations are treated as non-conservative terms rather than point-wise source terms, following:We implement the non-conservative term

flux_nonconservative_waruszewski, which provides well-balancedness (to machine precision accuracy) for isothermal hydrostatic equilibria:Other standard benchmark tests are provided as well:
RisingBubble_afterBugFix_lmars.mp4