Remove code with alpha1/2 to fix failing tests#116
Remove code with alpha1/2 to fix failing tests#116patrickersing merged 3 commits intotrixi-framework:mainfrom
alpha1/2 to fix failing tests#116Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 99.33% 99.32% -0.00%
==========================================
Files 87 87
Lines 4600 4587 -13
==========================================
- Hits 4569 4556 -13
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Apologies from my side if my merge of #2588 caused this (although tests where passing back then) |
I also didn't think about that. There was no upstream test for subcell limiting in TrixiShallowWater.jl back then. But my changes still were breaking in some sense. |
patrickersing
left a comment
There was a problem hiding this comment.
LGTM!
Thanks a lot for fixing this.
In trixi-framework/Trixi.jl#2588, I removed
alpha1andalpha2. Now, everything is directly done withalpha.