Skip to content

Remove code with alpha1/2 to fix failing tests#116

Merged
patrickersing merged 3 commits intotrixi-framework:mainfrom
bennibolm:remove-alpha12
Oct 15, 2025
Merged

Remove code with alpha1/2 to fix failing tests#116
patrickersing merged 3 commits intotrixi-framework:mainfrom
bennibolm:remove-alpha12

Conversation

@bennibolm
Copy link
Copy Markdown
Contributor

In trixi-framework/Trixi.jl#2588, I removed alpha1 and alpha2. Now, everything is directly done with alpha.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (1b0d2f5) to head (9a5fa0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   99.33%   99.32%   -0.00%     
==========================================
  Files          87       87              
  Lines        4600     4587      -13     
==========================================
- Hits         4569     4556      -13     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennibolm bennibolm added the bug Something isn't working label Oct 9, 2025
@DanielDoehring
Copy link
Copy Markdown
Member

Apologies from my side if my merge of #2588 caused this (although tests where passing back then)

@bennibolm
Copy link
Copy Markdown
Contributor Author

Apologies from my side if my merge of #2588 caused this (although tests where passing back then)

I also didn't think about that. There was no upstream test for subcell limiting in TrixiShallowWater.jl back then. But my changes still were breaking in some sense.
Hopefully, there will be no problems anymore with the new test.

Copy link
Copy Markdown
Member

@patrickersing patrickersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks a lot for fixing this.

@patrickersing patrickersing merged commit 0ef3984 into trixi-framework:main Oct 15, 2025
16 of 40 checks passed
@bennibolm bennibolm deleted the remove-alpha12 branch October 15, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants